Skip to content

Add version number when sending confirmations #12725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Add version number when sending confirmations #12725

merged 1 commit into from
Mar 30, 2022

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 23, 2022

Resolves brave/brave-browser#21836

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey self-assigned this Mar 23, 2022
@tmancey tmancey force-pushed the issues/21836 branch 2 times, most recently from 5443a5a to adab289 Compare March 25, 2022 13:24
@tmancey tmancey marked this pull request as ready for review March 25, 2022 13:29
@tmancey tmancey requested review from a team as code owners March 25, 2022 13:29
@github-actions github-actions bot added rebase and removed rebase labels Mar 25, 2022
@@ -8,5 +8,8 @@ specific_include_rules = {
],
"ad_notifications.cc": [
"+brave/common/brave_channel_info.h",
],
"version_number_user_data.cc": [
"+components/version_info",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be resolved by brave/brave-browser#13793

@tmancey tmancey force-pushed the issues/21836 branch 5 times, most recently from 35215c1 to 5cb0bc4 Compare March 25, 2022 16:12
@tmancey tmancey force-pushed the issues/21836 branch 4 times, most recently from e16b28a to d51fdef Compare March 29, 2022 14:52
@tmancey
Copy link
Collaborator Author

tmancey commented Mar 29, 2022

CI failed due to unrelated browser tests

@tmancey tmancey merged commit 5336e28 into master Mar 30, 2022
@tmancey tmancey deleted the issues/21836 branch March 30, 2022 00:23
@tmancey tmancey added this to the 1.39.x - Nightly milestone Mar 30, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.39.73 Chromium: 101.0.4951.34 (Official Build) nightly (64-bit)
Revision 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS Ubuntu 18.04 LTS

Verified versionNumber is attached to the confirmation request

view
image
image

dismissed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version number when sending confirmations
4 participants