Skip to content

Add version number when sending confirmations #21836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmancey opened this issue Mar 23, 2022 · 2 comments · Fixed by brave/brave-core#12725
Closed

Add version number when sending confirmations #21836

tmancey opened this issue Mar 23, 2022 · 2 comments · Fixed by brave/brave-core#12725
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 23, 2022 •
edited
Loading

Add version number to payload when sending confirmations, i.e. {"versionNumber":"1.2.3.4"}
@tmancey tmancey self-assigned this Mar 23, 2022
This was referenced Mar 23, 2022
Merged
Closed
@tmancey tmancey added this to the 1.39.x - Nightly milestone Mar 30, 2022
@tmancey tmancey mentioned this issue Apr 20, 2022
Merged
4 tasks
@kjozwiak
Copy link
Member

Above will require 1.38.104 or higher for 1.38.x verification.

@btlechowski
Copy link

Verification passed on

Brave 1.38.105 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Ubuntu 18.04 LTS

image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Add version number when sending confirmations brave/brave-core
3 participants
@tmancey @kjozwiak @btlechowski