Skip to content

Add a Chromium feature for if rewards card should show during Onboarding #12519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

bsclifton
Copy link
Member

Add a Chromium feature for if rewards card should show during Onboarding
Defaulted to FALSE

Fixes brave/brave-browser#21400

cc: @rebron

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton requested review from simonhong and a team March 8, 2022 00:47
@bsclifton bsclifton self-assigned this Mar 8, 2022
@bsclifton bsclifton requested review from emerick and szilardszaloki and removed request for a team March 8, 2022 00:47
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Mar 8, 2022
@emerick emerick requested a review from zenparsing March 8, 2022 01:02
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton bsclifton force-pushed the bsc-rewards-onboarding-griffin branch from 5aeed08 to b281ff0 Compare March 8, 2022 06:06
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick self-requested a review March 8, 2022 18:23
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.38.33 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 11 Version 21H2 (Build 22000.527)

Went through the STR/Cases outlined via brave/brave-browser#21400 (comment) and ensured the following:

Before fix

Example Example Example Example
OB1 OB2 OB3 OB4

After fix

Example Example Example
OB1 OB2 OB3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Brave Rewards card (during brave://welcome)
6 participants