-
Notifications
You must be signed in to change notification settings - Fork 977
Add a Chromium feature for if rewards card should show during Onboarding #12519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A Storybook has been deployed to preview UI for the latest push |
Defaulted to FALSE Fixes brave/brave-browser#21400
5aeed08
to
b281ff0
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verification PASSED on
Went through the STR/Cases outlined via brave/brave-browser#21400 (comment) and ensured the following:
|
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
After fix
Example |
Example |
Example |
---|---|---|
![]() |
![]() |
![]() |
Add a Chromium feature for if rewards card should show during Onboarding
Defaulted to FALSE
Fixes brave/brave-browser#21400
cc: @rebron
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: