Skip to content

Hide Brave Rewards card (during brave://welcome) #21400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bsclifton opened this issue Mar 2, 2022 · 3 comments · Fixed by brave/brave-core#12519
Closed

Hide Brave Rewards card (during brave://welcome) #21400

bsclifton opened this issue Mar 2, 2022 · 3 comments · Fixed by brave/brave-core#12519

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 2, 2022

Test plan

  1. Fresh profile
  2. Launch Brave
  3. brave://welcome screen will show
  4. Hit next until you get to end
  5. Brave Rewards card should NOT show

Description

Desktop onboarding shows brave://welcome which acts as a welcome tour. It has an intro card, import, shields and P3A, and lastly Brave Rewards. We should tie the the Brave Rewards card to a configuration value so that we can easily turn on and off

Let's default this to off to start

@bsclifton
Copy link
Member Author

bsclifton commented Mar 2, 2022

This might not be possible to take effect on first launch; the value won't be fetched from variation service until 2nd launch

https://github.com/brave/brave-variations#some-notes-on-using-variations-in-the-browser

Studies only take effect after restarting the browser.

bsclifton added a commit to brave/brave-core that referenced this issue Mar 2, 2022
@bsclifton bsclifton changed the title Have Brave Rewards card (during brave://welcome) be configurable via Griffin Hide Brave Rewards card (during brave://welcome) Mar 8, 2022
@bsclifton bsclifton added QA/Yes and removed griffin labels Mar 8, 2022
bsclifton added a commit to brave/brave-core that referenced this issue Mar 8, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 8, 2022
@rebron
Copy link
Collaborator

rebron commented Mar 8, 2022

Related issue: #21202

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 15, 2022

Verification PASSED on

Brave | 1.36.115 Chromium: 99.0.4844.51 (Official Build) (64-bit)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)

  • Verified the description from the issue and confirmed Brave Rewards card is removed from the welcome onboarding flow in both clean and upgraded profile

Clean profile

Example Example Example Example
image image image image

Upgrade profile

1.36.112

Example Example Example Example Example
image image image image image

After upgrade to 1.36.115

Example Example Example Example
image image image image

Verified using

Brave | 1.36.115 Chromium: 99.0.4844.51 (Official Build) (x86_64)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | macOS Version 12.2.1 (Build 21D62)

Verified test plan from #21400 (comment)

  • Confirmed rewards card is no longer visible from brave://welcome
First Second Final
1 2 3

Verification passed on

Brave 1.36.115 Chromium: 99.0.4844.51 (Official Build) (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS
  • Confirmed rewards card is no longer visible from brave://welcome

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment