-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Hide Brave Rewards card (during brave://welcome) #21400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This might not be possible to take effect on first launch; the value won't be fetched from variation service until 2nd launch https://github.com/brave/brave-variations#some-notes-on-using-variations-in-the-browser
|
Attempt at solving brave/brave-browser#21400
Defaulted to FALSE Fixes brave/brave-browser#21400
Related issue: #21202 |
Verification PASSED on
Clean profile
Upgrade profile 1.36.112
After upgrade to 1.36.115
Verified using
Verified test plan from #21400 (comment)
Verification passed on
|
Test plan
Description
Desktop onboarding shows
brave://welcome
which acts as a welcome tour. It has an intro card, import, shields and P3A, and lastly Brave Rewards. We should tie the the Brave Rewards card to a configuration value so that we can easily turn on and offLet's default this to off to start
The text was updated successfully, but these errors were encountered: