-
Notifications
You must be signed in to change notification settings - Fork 966
Add NTP sponsored images frequency capping. #11945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f98053f
to
8482f44
Compare
8482f44
to
3a4b39a
Compare
3a4b39a
to
ea97398
Compare
896ac53
to
8c5df23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ DEPS
8c5df23
to
7625160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ntp_background_images ++
7625160
to
9a427a5
Compare
components/ntp_background_images/browser/ntp_sponsored_images_data.cc
Outdated
Show resolved
Hide resolved
components/ntp_background_images/browser/ntp_sponsored_images_data.cc
Outdated
Show resolved
Hide resolved
9a427a5
to
29c4ce6
Compare
f7069c2
to
fcaf023
Compare
0567fd2
to
122f058
Compare
0fea4ea
to
212267b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at the wrong callback type, thanks, iOS++
components/ntp_background_images/browser/view_counter_service.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/ads/new_tab_page_ads/new_tab_page_ad.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++ (added a couple nits)
212267b
to
f8e707e
Compare
f8e707e
to
00d9a51
Compare
9673e76
to
11a3608
Compare
11a3608
to
25c169e
Compare
Now information about which SI should be rendered on NTP is requested from ads library.
NTP tries to render SI each 4th view. SI could be frequency capped. In this case NTP renders background wallpaper.
If Brave Ads are disabled, then frequency capping is not applied and SI is shown each 4th NTP view.
Resolves brave/brave-browser#14015
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Case 1
New tab page ad not served
Case 2
Served new tab page ad
Viewed new tab page ad with placement id
andSuccessfully logged new tab page ad viewed event
.New tab page ad not served
message in rewards log.