Skip to content

Send Brave Ads NTP SI view event when NTP page is displayed #20851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aseren opened this issue Feb 2, 2022 · 1 comment
Closed

Send Brave Ads NTP SI view event when NTP page is displayed #20851

aseren opened this issue Feb 2, 2022 · 1 comment
Assignees
@aseren
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@aseren
Copy link

aseren commented Feb 2, 2022 •
edited by tmancey
Loading

NTP SI view event is currently sent when the page starts loading, but should be sent when the page has fully loaded (displayed)
@aseren aseren added OS/Android Fixes related to Android browser functionality OS/Desktop feature/ads labels Feb 2, 2022
@tmancey tmancey changed the title Send SI view event when NTP page is displayed. Send Brave Ads NTP SI view event when NTP page is displayed Feb 15, 2022
@tmancey tmancey added the OS/iOS Fixes related to iOS browser functionality label Feb 15, 2022
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 28, 2022
@tmancey
Copy link
Contributor

tmancey commented Mar 3, 2022

Closing as resolved by brave/brave-core#11945 cc @aseren

@tmancey tmancey closed this as completed Mar 3, 2022
@tmancey tmancey added QA/No closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed OS/iOS Fixes related to iOS browser functionality QA/Yes labels Mar 3, 2022
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. enhancement feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @aseren