Skip to content

Improve hardware wallet account naming #11684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 25, 2021
Merged

Improve hardware wallet account naming #11684

merged 4 commits into from
Dec 25, 2021

Conversation

onyb
Copy link
Member

@onyb onyb commented Dec 23, 2021

Overview

  • Remove custom HardwareWalletAccount type and use the Mojom type instead.
  • Pre-select hardware wallet accounts that were previously added, and disable the checkboxes.
  • Use derivation index and scheme for default hardware wallet account names.
  • Sort hardware wallet accounts alphabetically by name.

Resolves brave/brave-browser#19507.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Demo

New HW account naming Legacy index 3 account is preselected

@onyb onyb requested review from bbondy, Douglashdaniel, muliswilliam and a team December 23, 2021 08:59
@onyb onyb self-assigned this Dec 23, 2021
@onyb onyb force-pushed the f/wallet/hw-add-improve branch from 61e50ea to 98aac0f Compare December 24, 2021 16:15
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb merged commit 8170290 into master Dec 25, 2021
@onyb onyb deleted the f/wallet/hw-add-improve branch December 25, 2021 13:14
@onyb onyb added this to the 1.35.x - Nightly milestone Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort hardware wallet addresses by index order vs alphabetically by address
3 participants