Skip to content

Sort hardware wallet addresses by index order vs alphabetically by address #19507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamesmudgett opened this issue Nov 16, 2021 · 1 comment · Fixed by brave/brave-core#11684
Closed

Sort hardware wallet addresses by index order vs alphabetically by address #19507

jamesmudgett opened this issue Nov 16, 2021 · 1 comment · Fixed by brave/brave-core#11684
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@jamesmudgett
Copy link

Screen Shot 2021-11-16 at 12 39 36 PM
@jamesmudgett jamesmudgett added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 16, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 16, 2021
@onyb onyb self-assigned this Dec 22, 2021
@onyb onyb mentioned this issue Dec 23, 2021
Merged
25 tasks
@onyb onyb added QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 23, 2021
@onyb onyb added this to the 1.35.x - Nightly milestone Dec 25, 2021
@srirambv
Copy link
Contributor

Brave 1.35.93 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11684
  • Verified new naming convention is used for both new and legacy wallets addresses
New HW account naming
Legacy index 3 account is preselected

@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Improve hardware wallet account naming brave/brave-core
4 participants
@jamesmudgett @bbondy @onyb @srirambv