Skip to content

Use Common Password Validation on Desktop #11456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

Douglashdaniel
Copy link
Contributor

Description

Password validations on Desktop are now using the isStrongPassword method from keyringController to be consistent with IOS and Android validations.

Resolves brave/brave-browser#19875

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2021-12-06.at.2.03.23.PM.mov

@Douglashdaniel Douglashdaniel force-pushed the use-common-password-validation branch from bf9a9ab to bf019fc Compare December 6, 2021 22:31
@Douglashdaniel Douglashdaniel force-pushed the use-common-password-validation branch from bf019fc to 094330c Compare December 7, 2021 01:05
@Douglashdaniel Douglashdaniel added this to the 1.35.x - Nightly milestone Dec 7, 2021
@Douglashdaniel Douglashdaniel merged commit a1ee305 into master Dec 7, 2021
@Douglashdaniel Douglashdaniel deleted the use-common-password-validation branch December 7, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Common Password Validation on Desktop
2 participants