Skip to content

Use Common Password Validation on Desktop #19875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Douglashdaniel opened this issue Dec 2, 2021 · 1 comment · Fixed by brave/brave-core#11456
Closed

Use Common Password Validation on Desktop #19875

Douglashdaniel opened this issue Dec 2, 2021 · 1 comment · Fixed by brave/brave-core#11456
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@Douglashdaniel
Copy link

There is a new method in KeyringController with a name IsStrongPassword. We should call it for a password validation to be consistent with other platforms.
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Dec 2, 2021
@Douglashdaniel Douglashdaniel self-assigned this Dec 2, 2021
This was referenced Dec 6, 2021
Merged
Merged
@Douglashdaniel Douglashdaniel added this to the 1.35.x - Nightly milestone Dec 8, 2021
@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2022

Brave 1.35.98 Chromium: 98.0.4758.72 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11456
  • Verified password field checks for the min criteria to be satisfied
  • Verified password field throws error when min criteria is not met
Length not satisfied
Special char/number not satisfied but min length satisfied
Password criteria satisfied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Use Common Password Validation on Desktop brave/brave-core
2 participants
@srirambv @Douglashdaniel