Skip to content

Improvements to the Site Permissions Panel #11486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Dec 7, 2021

Description

Improvements to the Site Permissions Panel

  1. Updated the UI to match the new design in Figma.
  2. Added a New account button to redirect to the Add Account modal.
  3. Added the ability to Connect to a site origin from the Permissions panel.
  4. Added the ability to Switch accounts for a site origin in the Permissions panel.
  5. Will now update your Selected Account if you Disconnect from a site origin.

Resolves brave/brave-browser#19954

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen.Recording.2021-12-07.at.2.09.14.PM.mov

@Douglashdaniel Douglashdaniel self-assigned this Dec 7, 2021
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner December 7, 2021 21:37
@Douglashdaniel Douglashdaniel force-pushed the site-permission-panel-improvements branch from ae0926a to b3742ea Compare December 9, 2021 14:23
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/brave_wallet/ changes ++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Add Ethereum Site Permissions in UI
3 participants