Skip to content

Do not show NTP sponsored images if the user has exceeded the frequency caps #11367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2021
Merged

Do not show NTP sponsored images if the user has exceeded the frequency caps #11367

merged 1 commit into from
Dec 10, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 1, 2021 •
edited
Loading

Resolves brave/brave-browser#14015

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This PR does not need testing as the new code is not executed. Will be QA'd with brave/brave-browser#14015

@tmancey tmancey self-assigned this Dec 1, 2021
@tmancey tmancey requested review from a team as code owners December 1, 2021 16:20
@tmancey tmancey marked this pull request as draft December 1, 2021 16:20
@tmancey tmancey force-pushed the issues/14015 branch 3 times, most recently from f3e0160 to 06903e3 Compare December 1, 2021 19:34
@tmancey tmancey changed the title Add new tab page ad serving support to the ads library Do not show NTP sponsored images if the user has exceeded the frequency caps Dec 1, 2021
@tmancey tmancey force-pushed the issues/14015 branch 4 times, most recently from c404942 to 599d23b Compare December 6, 2021 16:14
@tmancey tmancey merged commit 580ef81 into master Dec 10, 2021
@tmancey tmancey deleted the issues/14015 branch December 10, 2021 14:19
@tmancey tmancey mentioned this pull request Dec 10, 2021
Merged
@tmancey tmancey restored the issues/14015 branch December 10, 2021 14:22
@tmancey tmancey deleted the issues/14015 branch December 10, 2021 14:25
@tmancey
Copy link
Collaborator Author

tmancey commented Dec 10, 2021

Closed as no longer needed

@tmancey tmancey requested review from emerick and removed request for a team, bsclifton and szilardszaloki December 10, 2021 14:41
@tmancey tmancey added this to the 1.35.x - Nightly milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick Awaiting requested review from emerick

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging this pull request may close these issues.

Do not show NTP sponsored images if the user has exceeded the frequency caps
1 participant
@tmancey