Skip to content

Do not allow to remove the active network on brave://settings/wallet/networks #11234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Nov 23, 2021

Resolves brave/brave-browser#19678

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Go to brave://settings/wallet/networks
  • Add custom networks
  • Set custom network as active in popup
  • Try to remove it on page

@spylogsster spylogsster requested a review from bbondy November 23, 2021 08:08
@spylogsster spylogsster self-assigned this Nov 23, 2021
@spylogsster spylogsster changed the title Do not remove active network Do not allow to remove the active network on brave://settings/wallet/networks Nov 23, 2021
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.34.40 Chromium: 96.0.4664.45 (Official Build) nightly (x86_64 translated)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 12.0.1 (Build 21A559)
  • Verified unable to remove a custom network when it is set as default
  • Verified there is no menu shown next to the custom network when it is set as default
11234.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow deleting the active network on brave://settings/wallet/networks
3 participants