Skip to content

Commit 2d79b3c

Browse files
committed
Do not remove active network (#11234)
1 parent b554622 commit 2d79b3c

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

browser/resources/settings/brave_wallet_page/wallet_networks_subpage.html

+2-1
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,14 @@
3636
<template>
3737
<div on-dblclick=onItemDoubleClick>
3838
<div class="settings-box">
39-
<div class="flex cr-padded-text hovered">
39+
<div class$=[[getNetworkItemClass(item.chainId)]]>
4040
<div><span hidden="[[hideNativeCurrencyInfo]]">({{item.nativeCurrency.name}}) </span>{{item.chainName}}</div>
4141
<div class="secondary">[[getItemDescritionText(item)]]</div>
4242
</div>
4343
<cr-icon-button class="icon-more-vert"
4444
on-click="onNetworkMenuTapped_"
4545
itemName=[[item.name]]
46+
hidden=[[isDefaultNetwork(item.chainId)]]
4647
focus-type="menu">
4748
</cr-icon-button>
4849
</div>

browser/resources/settings/brave_wallet_page/wallet_networks_subpage.js

+19-2
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,13 @@ class SettingsWalletNetworksSubpage extends SettingsWalletNetworksSubpageBase {
6464
this.updateNetworks()
6565
}
6666

67+
getNetworkItemClass(chainId) {
68+
if (!this.isDefaultNetwork(chainId)) {
69+
return "flex cr-padded-text hovered"
70+
}
71+
return "flex cr-padded-text"
72+
}
73+
6774
isDefaultNetwork(chainId) {
6875
return (chainId ===
6976
this.getPref('brave.wallet.wallet_current_chain_id').value)
@@ -79,14 +86,20 @@ class SettingsWalletNetworksSubpage extends SettingsWalletNetworksSubpageBase {
7986
}
8087

8188
onDeleteActionTapped_(event) {
89+
const chainId = this.selectedNetwork.chainId
90+
const chainName = this.selectedNetwork.chainName
8291
this.selectedNetwork = {}
8392
this.$$('cr-action-menu').close();
93+
if (this.isDefaultNetwork(chainId)) {
94+
this.updateNetworks()
95+
return
96+
}
8497
var message = this.i18n('walletDeleteNetworkConfirmation',
85-
event.model.item.chainName)
98+
chainName)
8699
if (!window.confirm(message))
87100
return
88101

89-
this.browserProxy_.removeEthereumChain(event.model.item.chainId).
102+
this.browserProxy_.removeEthereumChain(chainId).
90103
then(success => { this.updateNetworks() })
91104
}
92105

@@ -95,6 +108,10 @@ class SettingsWalletNetworksSubpage extends SettingsWalletNetworksSubpageBase {
95108
}
96109

97110
onItemDoubleClick(event) {
111+
if (this.isDefaultNetwork(event.model.item.chainId)) {
112+
this.updateNetworks()
113+
return
114+
}
98115
this.selectedNetwork = event.model.item
99116
this.showAddWalletNetworkDialog_ = true
100117
}

0 commit comments

Comments
 (0)