Skip to content

Enable Greaselion features only after rules are ready (uplift to 1.30.x) #10023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Sep 9, 2021

Uplift of #10001

…e-profiles

Enable Greaselion features only after rules are ready
@emerick emerick added this to the 1.30.x - Beta milestone Sep 9, 2021
@emerick emerick requested a review from a team September 9, 2021 20:41
@emerick emerick self-assigned this Sep 9, 2021
@emerick emerick requested a review from a team as a code owner September 9, 2021 20:41
@emerick emerick requested review from bsclifton and zenparsing and removed request for a team, bsclifton and zenparsing September 9, 2021 20:41
@kjozwiak
Copy link
Member

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-greaselion-preconditions-multiple-profiles_1.30.x-macos/1/execution/node/140/log/.

 FAILED: obj/brave/browser/widevine/widevine/widevine_utils.o 

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.30.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10001 (comment).

@kjozwiak kjozwiak merged commit ca4ee5f into 1.30.x Sep 12, 2021
@kjozwiak kjozwiak deleted the greaselion-preconditions-multiple-profiles_1.30.x branch September 12, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants