-
Notifications
You must be signed in to change notification settings - Fork 966
Enable Greaselion features only after rules are ready #10001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilgrim-brave
approved these changes
Sep 8, 2021
zenparsing
approved these changes
Sep 9, 2021
1e48ad7
to
69e9cf6
Compare
CI passed on all platforms except Mac; restarting Mac. |
69e9cf6
to
f970363
Compare
f970363
to
bcb0209
Compare
Mac passed CI; ready to merge. |
emerick
added a commit
that referenced
this pull request
Sep 9, 2021
…e-profiles Enable Greaselion features only after rules are ready
emerick
added a commit
that referenced
this pull request
Sep 9, 2021
…e-profiles Enable Greaselion features only after rules are ready
Verified
Steps:
Confirmed my Ads-enabled state was detected and I was able to make a Brave Talk call.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#17914
Don't enable Greaselion features until Greaselion signals that all of its rules are downloaded.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See STR in brave/brave-browser#17914.