Skip to content

Enable Greaselion features only after rules are ready #10001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Sep 8, 2021

Resolves brave/brave-browser#17914

Don't enable Greaselion features until Greaselion signals that all of its rules are downloaded.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See STR in brave/brave-browser#17914.

@emerick emerick requested a review from a team as a code owner September 8, 2021 11:05
@emerick emerick self-assigned this Sep 8, 2021
@emerick emerick requested review from deeppandya and removed request for deeppandya September 8, 2021 11:05
@emerick emerick force-pushed the greaselion-preconditions-multiple-profiles branch 2 times, most recently from 1e48ad7 to 69e9cf6 Compare September 9, 2021 14:33
@emerick emerick added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Sep 9, 2021
@emerick
Copy link
Contributor Author

emerick commented Sep 9, 2021

CI passed on all platforms except Mac; restarting Mac.

@emerick emerick force-pushed the greaselion-preconditions-multiple-profiles branch from 69e9cf6 to f970363 Compare September 9, 2021 18:20
@emerick emerick force-pushed the greaselion-preconditions-multiple-profiles branch from f970363 to bcb0209 Compare September 9, 2021 18:53
@emerick
Copy link
Contributor Author

emerick commented Sep 9, 2021

Mac passed CI; ready to merge.

@emerick emerick merged commit c64649e into master Sep 9, 2021
@emerick emerick deleted the greaselion-preconditions-multiple-profiles branch September 9, 2021 20:14
@emerick emerick added this to the 1.31.x - Nightly milestone Sep 9, 2021
emerick added a commit that referenced this pull request Sep 9, 2021
…e-profiles

Enable Greaselion features only after rules are ready
emerick added a commit that referenced this pull request Sep 9, 2021
…e-profiles

Enable Greaselion features only after rules are ready
@emerick emerick removed CI/skip-android Do not run CI builds for Android CI/skip-linux labels Sep 9, 2021
@emerick emerick removed CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Sep 9, 2021
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.31.33 Chromium: 93.0.4577.63 (Official Build) nightly (x86_64)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. clean profile
  2. launched Brave
  3. clicked on Start using Rewards
  4. created a 2nd profile (but didn't enable Ads)
  5. relaunched Brave
  6. chose my original profile with Ads enabled
  7. went to beta.talk.brave.com and clicked Start call

Confirmed my Ads-enabled state was detected and I was able to make a Brave Talk call.

example example example example example example
Screen Shot 2021-09-10 at 8 59 44 AM Screen Shot 2021-09-10 at 9 00 03 AM Screen Shot 2021-09-10 at 9 00 13 AM Screen Shot 2021-09-10 at 9 00 37 AM Screen Shot 2021-09-10 at 9 00 42 AM Screen Shot 2021-09-10 at 9 00 46 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Talk not recognizing when rewards is enabled, because Greaselion precondition not met
4 participants