Skip to content

Fix 8127: Update GetChange to remove the author arg (uplift for 1.3.x) #8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Feb 8, 2020

Fix #8127
Uplift for #8130

Fix 8127: Update GetChange to remove the author arg
@jumde jumde self-assigned this Feb 8, 2020
@jumde jumde requested a review from a team February 8, 2020 20:42
@jumde jumde added this to the 1.3.x - Release Hotfix 1 milestone Feb 8, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 9, 2020

Restarting due to the earlier init issues and CIPD not being downloaded and running into a 403.

@jumde
Copy link
Contributor Author

jumde commented Feb 9, 2020

test-install failed for the latest run

@kjozwiak
Copy link
Member

As per #8145 (comment), only test-install failed on macOS which is a known issue and not related to this specific PR:

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x approved after deliberating with @brave/uplift-approvers. As per #8145 (comment), the only failure was test-install on macOS. However, these are known issues and are not related to this specific PR.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 5c0d434 into 1.3.x Feb 10, 2020
@kjozwiak kjozwiak deleted the 1.3.x_8127 branch February 10, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants