-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix 8127: Update GetChange to remove the author arg #8130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaiplesa
previously approved these changes
Feb 7, 2020
a04f033
to
bdbd110
Compare
yrliou
previously approved these changes
Feb 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bridiver
previously approved these changes
Feb 7, 2020
git_cl.py was recently updated to change the function arguments for cl.GetChange. https://chromium.googlesource.com/chromium/tools/depot_tools/+/7f6dec01696fa5319c505ca8f57579a5b02c4184%5E%21/git_cl.py Updating the lint script to match the args.
bdbd110
to
356cd74
Compare
yrliou
approved these changes
Feb 7, 2020
@jumde does this need to go into |
jumde
added a commit
that referenced
this pull request
Feb 8, 2020
Fix 8127: Update GetChange to remove the author arg
jumde
added a commit
that referenced
this pull request
Feb 8, 2020
Fix 8127: Update GetChange to remove the author arg
jumde
added a commit
that referenced
this pull request
Feb 8, 2020
Fix 8127: Update GetChange to remove the author arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8127
git_cl.py was recently updated to change the function arguments for cl.GetChange.
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7f6dec01696fa5319c505ca8f57579a5b02c4184%5E%21/git_cl.py
Updating the lint script to match the args.
Submitter Checklist:
git rebase master
(if needed).git rebase -i
to squash commits (if needed).added to
scripts/audit.js
.Test Plan:
.cc
file to remove the first line of the file license.npm run lint
, you should get an errorReviewer Checklist:
After-merge Checklist:
changes has landed on.