Skip to content

Fix 8127: Update GetChange to remove the author arg #8130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Feb 7, 2020

Fix #8127
git_cl.py was recently updated to change the function arguments for cl.GetChange.
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7f6dec01696fa5319c505ca8f57579a5b02c4184%5E%21/git_cl.py

Updating the lint script to match the args.

Submitter Checklist:

Test Plan:

  1. Edit any .cc file to remove the first line of the file license.
  2. run npm run lint, you should get an error

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde self-assigned this Feb 7, 2020
mihaiplesa
mihaiplesa previously approved these changes Feb 7, 2020
yrliou
yrliou previously approved these changes Feb 7, 2020
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bridiver
bridiver previously approved these changes Feb 7, 2020
git_cl.py was recently updated to change the function arguments for cl.GetChange.
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7f6dec01696fa5319c505ca8f57579a5b02c4184%5E%21/git_cl.py

Updating the lint script to match the args.
@jumde jumde dismissed stale reviews from bridiver and yrliou via 356cd74 February 7, 2020 22:26
@jumde jumde force-pushed the lint_cl_getchange branch from bdbd110 to 356cd74 Compare February 7, 2020 22:26
@jumde jumde merged commit 3659421 into master Feb 8, 2020
@jumde jumde deleted the lint_cl_getchange branch February 8, 2020 01:51
@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2020

@jumde does this need to go into 1.5.x, 1.4.x and 1.3.x as well? Or does the PR builder always use master?

jumde added a commit that referenced this pull request Feb 8, 2020
Fix 8127: Update GetChange to remove the author arg
jumde added a commit that referenced this pull request Feb 8, 2020
Fix 8127: Update GetChange to remove the author arg
jumde added a commit that referenced this pull request Feb 8, 2020
Fix 8127: Update GetChange to remove the author arg
@kjozwiak kjozwiak added this to the 1.6.x - Nightly milestone Feb 12, 2020
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix lint issue in CI pipeline
6 participants