-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Binance widget and autocomplete shouldn't use /en/ for all locales #9691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
bbondy opened this issue
May 8, 2020
· 2 comments
· Fixed by brave/brave-core#7626 or brave/brave-core#7657
Closed
Binance widget and autocomplete shouldn't use /en/ for all locales #9691
bbondy opened this issue
May 8, 2020
· 2 comments
· Fixed by brave/brave-core#7626 or brave/brave-core#7657
Labels
feature/autocomplete
feature/widgets
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Jan 15, 2021
23 tasks
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Jan 18, 2021
23 tasks
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Jan 20, 2021
Verification passed on
EN.mov
FR.mov
Greek.movVerification passed on
EN.mov
German.mov
Finnish.movVerification passed on
EN_mac.mov
Spanish.mov
Kannada.mov |
Verification passed on Samsung Tab A with Android 10 running 1.21.70 x64 build
Tablet-EN.mp4
Tablet-NL.mp4
Tablet-HI.mp4Verification passed on OnePlus 6T with Android 10 running 1.21.70 x64 build
ARM-EN.mp4
ARM-RO.mp4
ARM-ML.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/autocomplete
feature/widgets
OS/Android
Fixes related to Android browser functionality
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/include
The Binance widget and autocomplete for site suggestions currently uses URLs with paths
/en/
We should use one of these locales if they match first:
Test Plan
Autocomplete does not apply for Android
.com
https://www.binance.com/en/
brave://settings
, turn on suggested sitesbitcoin
binance.com/en/
is shown as the suggested siteThe text was updated successfully, but these errors were encountered: