Skip to content

[Widget] Brave suggested auto-complete shows up for unsupported regions #14314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srirambv opened this issue Feb 23, 2021 · 0 comments
Open

Comments

@srirambv
Copy link
Contributor

Description

[Follow-up to #9691] Brave suggested auto-complete shows up for unsupported regions

Steps to Reproduce

  1. Set locale to JP
  2. Clean install Brave beta that has the fix for Binance widget and autocomplete shouldn't use /en/ for all locales #9691
  3. Enable Brave suggested sites from settings
  4. Type bitcoin in URL bar, shows suggestion that loads region specific localised page

Actual result:

JP.Brave.Suggested.Autocomplete.mov

Expected result:

Probably list https://www.binance.com/en/ pages for unsupported region even if localised page is available

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.21.65 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant