Skip to content

[C132] Bottom toolbar is active in phone landscape mode #43925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 6 tasks
samartnik opened this issue Feb 12, 2025 · 1 comment · Fixed by brave/brave-core#27624
Closed
3 of 6 tasks

[C132] Bottom toolbar is active in phone landscape mode #43925

samartnik opened this issue Feb 12, 2025 · 1 comment · Fixed by brave/brave-core#27624
Assignees

Comments

@samartnik
Copy link
Contributor

Description

Bottom toolbar is active in phone landscape mode (see picture). This a regression from this C132 commit https://chromium.googlesource.com/chromium/src/+/8c7ff112c0ebadc79c298d02acc0082cb560e6ec

Image

Steps to reproduce

  1. In phone turn to the landscape mode
  2. Bottom toolbar is active

Actual result

Bottom toolbar is active

Expected result

Bottom toolbar is gone, menu and tab switcher moved to the top toolbar

Reproduces how often

Easily reproduced

Brave version

1.75.x

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Feb 12, 2025
@samartnik samartnik self-assigned this Feb 12, 2025
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 13, 2025
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 18, 2025
@hffvld
Copy link
Contributor

hffvld commented Mar 18, 2025

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 16 BP22.250103.008 release-keys
Brave build: 1.77.82 
Chromium: 134.0.6998.95 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the STR/TP from [C132] Bottom toolbar is active in phone landscape mode #43925 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the bottom toolbar is not shown while phone is in Landscape Mode.
  • Verified the same when the bottom toolbar is On and Off.

1 2
1 2
1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants