Skip to content

[Android] Enforce full method signature check for bytecode tests #44049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6 tasks
samartnik opened this issue Feb 17, 2025 · 0 comments · Fixed by brave/brave-core#27701
Closed
6 tasks

[Android] Enforce full method signature check for bytecode tests #44049

samartnik opened this issue Feb 17, 2025 · 0 comments · Fixed by brave/brave-core#27701
Assignees
@samartnik
Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Milestone
1.77.x - Release

Comments

@samartnik
Copy link
Contributor

Description

We have already had a few occasions recently when bytecode patches were not applied due to different method signature (the last being #43925). So we should enforce checking types for all methods to avoid this going forward.

Steps to reproduce

  1. n/a

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version

n/a

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.77.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Enforce full method signature check for bytecode tests brave/brave-core
1 participant
@samartnik