PWA Support is broken (crashes) #3750
Comments
rebron
added
priority/P2
|
cc: @rebron to add steps to reproduce |
|
If I am right, I already added. |
|
Same issue on MacOS when trying to open an installed PWA, works fine with Chrome... Error Stack
|
|
App never launches. Doesn't crash browser though. details
Process: app_mode_loader [16144] Date/Time: 2019-03-25 09:54:46.290 -0700 Sleep/Wake UUID: 0B305DAD-19EC-41CA-9A92-F10DB07771E9 Time Awake Since Boot: 160000 seconds System Integrity Protection: enabled Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BREAKPOINT (SIGTRAP) Termination Signal: Trace/BPT trap: 5 Application Specific Information: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread Thread 1: Thread 2: Thread 0 crashed with X86 Thread State (64-bit): Logical CPU: 2 Binary Images: External Modification Summary: VM Region Summary: REGION TYPE SIZE COUNT (non-coalesced) |
|
Same here on Windows 10 1809 and Brave 0.62.50. |
|
It's happening because it links the website to the
It's not reproducible on Linux btw. This works there. |
Thank you, it works ! |
|
+1 from Community https://community.brave.com/t/shortcuts-dont-work-on-pc/53857?u=eljuno |
|
as @BenDavidson90 stated, another user from Community reports PWAs fixdd by changing |
|
Anyone have a fix for MacOS? Thank you in advance. |
|
@GauthamVarmaK @jordmccord @rebron Consider editing your comments to wrap the crash report in a "spoilers" area. This thread is difficult to navigate. |
|
Fix for Windows is merged - brave/brave-core#2544 |
|
+1 here |
|
For folks following along, this should be fixed in our Nightly channel 🎉 Huge thanks to @simonhong 😄 We're working to uplift the patch back to beta (0.66.x). That means the fixes will hit release channel ~July 2nd |
|
Verification PASSED on
|
|
Should this be fixed in Windows? It's still not working here, and the "change chrome_proxy.exe to brave.exe in the shortcut" workaround doesn't seem to work here, either. |
|
It's working now in my Mac Mojave. |
|
@JudahGabriel what version of Brave are you using on Windows? It should be working there |
|
@bsclifton Brave v0.68.132, on Windows 10 Enterprise. |
|
My repro steps:
|
|
Hmm, I can't repo on my Win10 home. It works well with |
|
Brave Version : Unfortunately, the problem report is not received in brave: // crashes. |
|
Still crashing for me |
|
Not working for YouTube Music (music.youtube.com). It doesn't open in it's own app but in a new tab in Brave. Tried changing chrome_proxy.exe to brave.exe, still same result. It appears to be working on other sites like YouTube, Spotify and GitHub even without changing the chrome_proxy.exe to brave.exe |
|
Still an issue here on Mac. It will open the shortcut just fine, but if you move the window it will crash. brave-bug.mov |
|
Shortcut opening broke on the most recent update for Mac OS (V1.35.104 for Mac). Shortcuts were working on previous version. Updating Brave broke the shortcuts, and re-generating the shortcuts does not fix. edit: Installed Brave Beta (V1.37.72 for Mac) and still has this issue. I am able to successfully create the shortcut and corresponding app/icon, but opening the app/icon causes the app to appear briefly in the dock before disappearing, and never opens a new window or appropriate web page. |
|
I am seeing the same behavior as @DeadDjembe after the most recent update for macOS. I tried looking through the logs in Console.app but didn't notice anything relevant. |
|
|
Appears to be working again. |
and others
Description
Facing problems with creating PWA by using the Create Shortcut option (with or without Open as window ) in the More Tools group under the Contorl and Customize Brave section. On creating a shortcut, it would create a shortcut on the Desktop. However on clicking the shortcut the PWA won't open and would load for ever
Potential work-around
See #3750 (comment)
Test plan / Steps to Reproduce
Actual result:
It would take forever to load
Expected result:
It should open up as a window or a tab
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17763.379
JavaScript V8 7.3.492.22
Flash (Disabled)
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36
Command Line "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=NewExtensionUpdaterService,DesktopPWAWindowing,fill-on-account-select --disable-features=AutofillServerCommunication,DefaultEnableOopRasterization,AudioServiceOutOfProcess,AutofillSaveCardSignInAfterLocalSave,UnifiedConsent,SharedArrayBuffer --flag-switches-begin --flag-switches-end
Executable Path C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path C:\Users\gauth\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations c134752e-f685ead3
2c707b42-dcf7018a
411b6d4e-3f4a17df
d01ab0d3-5ac8943
1a0d11d4-2f9febdf
66df3e9d-a85d0b2f
4b8c3f4-3f4a17df
b7e2524c-c92d551c
411c711e-3f4a17df
b3888d8d-afba0f91
8982496f-3f4a17df
61832c80-3f4a17df
cc20827f-77c422c
2db4845-ace4e138
74785582-3f4a17df
241fff6c-ddf20878
9853922b-3f4a17df
9def365c-3f4a17df
2342e907-3f4a17df
9ca1387e-3f4a17df
1c752ce9-1c752ce9
41e765a5-3f4a17df
ab3d6cfd-3f4a17df
776de70c-e0278d3d
ed9149a9-3f4a17df
a5cb8590-3f4a17df
34d450b1-3f4a17df
6c6c4f61-3f4a17df
76b48ab8-d4bd105c
c70841c8-a2567007
14bdbe54-e8c7a65b
d8343fa3-3f4a17df
b517d646-3f4a17df
8ee5ed19-c3125ea2
74658432-fa79b94c
f978f5fa-3f4a17df
c36cdb78-3f4a17df
9e201a2b-3f4a17df
27212adc-27212adc
591576c8-3f4a17df
5274eb09-3f4a17df
36115667-3f4a17df
ceff87ec-3f4a17df
44827ee5-3f4a17df
8ca44045-3f4a17df
3f79ac13-3d47f4f4
8f1e27f-3f4a17df
77bbdddc-3f4a17df
5485fc4d-3f4a17df
de47491b-3f4a17df
9b4c4257-3f4a17df
8fa604e0-ace4e138
43f62d3b-3f4a17df
4ae380f4-3f4a17df
9e5c75f1-30e1b12b
2594bdf4-3f4a17df
6fa07eb4-7282ca76
2981bcb4-3f4a17df
5139837c-3f4a17df
4934552d-3f4a17df
7f8176d9-3f4a17df
23a898eb-fc93cf74
7a5ba892-3f4a17df
d1cd70a5-80f9a33e
4ea303a6-3f4a17df
ac8d4708-e340be04
b19465ab-b19465ab
6e6e0c7e-3f17a7d8
95876445-2b71ffe4
2b33233e-881ca6c9
b363a81f-3f4a17df
4da5ae82-3f4a17df
56302f8c-2f882e70
dc5b1f29-dc5b1f29
bbc5c1b-3f4a17df
cc54eb06-803f8fc4
b2612322-8a9180b2
cac0a91c-3f4a17df
cec9a952-9a6c5085
f56e0452-3f4a17df
8576baf1-3f4a17df
f3ea30a0-3f4a17df
3038aa2e-3f4a17df
d00fcbde-3f4a17df
9a2f4e5b-4bc735ae
1354da85-f1a864dc
6844d8aa-669a04e0
494d8760-3f4a17df
f9e5da91-508355f5
fcdd9ed9-fcdd9ed9
3a4029d-d7f231f3
b0ea13bc-3f4a17df
3a8217c1-38848f64
94e68624-803f8fc4
cc73f8a1-3f4a17df
b4e8892d-a2d707c6
10a311eb-10a311eb
8834fcca-3f4a17df
6204e469-3f4a17df
Website problems only:
No the issue persists even if the shields are disabled
No it works properly on chrome
Additional Information
Would update the issue when it's working.
The text was updated successfully, but these errors were encountered: