-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Desktop] Crash while executing PWA #9006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This problem has existed for a long time and the brave team does not pay any attention to this issue! This is a |
Seeing this same behavior with Google Keep and Gmail, except that I am able to click inside the window and do things, including opening links in a new tab. Not sure if this helps, but I use Moom and I can use its window controls to resize/move the window without it crashing, but as mentioned above, normal dragging results in a crash.
|
@oky2abbas Is this still an issue for you on 1.9.72 our current release version from yesterday? |
@rebron I just tried 1.9.72 on my Mac and saw no improvement from my previous comment. |
@rjenkinsjr Sorry for inconvenience.
Can you delete and try again? thanks a lot. |
Installing and opening a PWA (like Twitter) is still crashing for me on Logs when launching Brave and then double clicking the Twitter PWA app in my Brave Browser Apps folder:
|
Same here. I tried following PWA's Carbon (The github login does not work in a normal tab BUT does work in chrome, might be related) MacOS 10.15.4 |
I have this issue as well. Originally reported here: I have since tried re-installing Brave, deleting all PWAs, turning off all extensions, and using a different profile. No dice. |
I have been experiencing the same issue and quite by chance I have discovered that it only happens when I have a productivity app called Window Tidy running. This is an app I've used for years to organise and resize apps on my desktop. I have never had an issue with it in the past, and I use it all the time - in fact I couldn't live without it. I doubt all the other users reporting this issue are using the same app, but maybe there is a common theme of apps that manage desktop layout, or something like that? Window Tidy is still available in the App Store should anyone want to install for debugging purposes. It has actually been superseded by another app by the same developers so I may try the free trial of that and report back on my findings. |
I had the same issue, but with a window management tool called Slate. Quitting Slate and launching a PWA app worked correctly. Interestingly, this issue doesn't appear to affect Chrome. I've since switched to Hammerspoon migrating my window management shortcuts and PWAs now work correctly in Brave. |
I think @andyjw7 and @sebflipper are onto something. Based on their findings, I narrowed my issue down to the the window snapping feature of BetterTouchTool - when I disable this feature, the problem goes away. I also use Moom which has a similar feature. I just tried it and it seems to work fine with PWAs, which is an acceptable solution for me. |
I use both BetterSnapTool, which I assume is a stripped-down BetterTouchTool, and AltTab, which is open-source. BetterSnapTool makes PWAs crash when I move their windows around; AltTab makes them crash immediately on startup. Quitting both apps resolves all issues. Seems like some disagreement with the accessibility APIs… |
After reading these comments, I resolved the issue by disabling a bunch of plugins that had accessibility permissions. I've since enabled all of them again and can still run my PWA's. So there's that... |
FWIW I've also experienced consistent crashes of the main Brave app immediately upon enabling the on-screen accessiblity keyboard. Dunno if it's related at all. |
@sebflipper @ThatsJustCheesy @rjenkinsjr thank a lot, this helped me narrow down the problem. I use amethyst as a window manager, & on disabling that, the brave PWA stopped crashing. BetterTouchTool snapping also causes the issue - but on moving it around. Maybe I should look at hammerspoon after all |
It's not the WM's fault, though? Chrome PWAs don't crash when I use amethyst, and neither do Edge's. |
@lukebrb Edge PWAs crash on using yabai though There's something about PWAs and window managers not working together. According to yabai dev, this could be a chromium issue koekeishiya/yabai#204 |
Same issue for me and Amethyst. Disabling it fixes PWAs. |
OS: I have no special window managers other than Moom. I quit Moom and am still getting PWAs that immediately close after opening. If I launch the PWA and activate a different application, e.g. tab out, the PWA stays open. But as soon as I activate the PWA window, it crashes. It does seem like it might be related to:
and
Here are crash logs when I try to use the messges.google.com PWA: Crash Report
|
Please also see the discussion in this bug report for BetterSnapTool:
While it may be people in this thread discussing issues with window managers, this hints at a greater accessibility issue which could be affecting users with other assistive technology when trying to use Brave with PWAs. That would make this rather a serious issue. Chromium seems to be handling this fine: |
I experienced the same crash while dragging a Brave PWA window when running BetterTouchTool for window snapping. Interestingly, Brave seems to work fine with window snapping when using Parallels Toolbox new Window Manager tool. |
Closing as duplicate of #7205 |
OS :
macOS 10.15.4
Version :
1.5.15
&1.5.23
Unfortunately, Brave crashes when running PWA applications.
I was able to log in from
app_mode_loader
.Note that this problem exists in all PWAs
Tested PWAs:
YouTube music & twitter & clickup
NOTE: Unfortunately, the problem report is not received in brave: // crashes.
Please fix this bug
The text was updated successfully, but these errors were encountered: