Skip to content

[Follow up to #36261][L10n] Some strings are not translated to Catalan language #37000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hffvld opened this issue Mar 22, 2024 · 3 comments · Fixed by brave/brave-core#22752
Closed

[Follow up to #36261][L10n] Some strings are not translated to Catalan language #37000

hffvld opened this issue Mar 22, 2024 · 3 comments · Fixed by brave/brave-core#22752
Labels
bug l10n OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.64.x - Release #2

Comments

@hffvld
Copy link
Contributor

hffvld commented Mar 22, 2024

Description:

Follow-up to #36261

Steps to Reproduce

  1. Set device language to Catalan
  2. Fresh install and launch Brave
  3. Three-dot menu > Settings > Observe
  4. Close the settings > Three-dot menu
  5. Leo > Observe
  6. Go through Leo's onboarding > Observe
  7. Tap ⚙️ button > Observe
  8. Go Premium > Observe
  9. Close > Tap ⚙️ button > Advanced settings > Observe

Actual result:

Observed that some strings are not translated to Catalan language:

  • All Leo related strings/screens are not translated
  • Shields & Privacy, Rewards, News not translated
1 2 3 4
1 2 3 4
1 2 3 4

Expected result:

All strings must be translated to the Catalan language.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version: 

Brave build: 1.64 (109)
BraveCore: 1.64.109 (123.0.6312.58)
  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? N/A
  • Can you reproduce this issue with the current build from AppStore? N/A

Device details: 

iPhone 14 / iOS 17.4

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information
@hffvld hffvld added bug l10n QA/Yes OS/iOS Fixes related to iOS browser functionality labels Mar 22, 2024
@hffvld hffvld mentioned this issue Mar 22, 2024
Closed
iccub added a commit to brave/brave-core that referenced this issue Mar 25, 2024
@iccub
[iOS] Add 1.64.x translations.
b689d22 
Resolves brave/brave-browser#37073
Resolves brave/brave-browser#37000
Also fixes one duplicated string. It's a debug string so no ticket
created for it.
@iccub iccub mentioned this issue Mar 25, 2024
Merged
24 tasks
iccub added a commit to brave/brave-core that referenced this issue Mar 25, 2024
@iccub
[iOS] Add 1.64.x translations.
f5b1bf3 
Resolves brave/brave-browser#37073
Resolves brave/brave-browser#37000
Also fixes one duplicated string. It's a debug string so no ticket
created for it.
iccub added a commit to brave/brave-core that referenced this issue Mar 25, 2024
@iccub
[iOS] Add 1.64.x translations.
3938df8 
Resolves brave/brave-browser#37073
Resolves brave/brave-browser#37000
Also fixes one duplicated string. It's a debug string so no ticket
created for it.
This was referenced Mar 25, 2024
Merged
Closed
@iccub iccub added this to the 1.64.x - Release #2 milestone Mar 25, 2024
@iccub
Copy link

iccub commented Mar 25, 2024

Added 1.64.x milestone. This gets fixed with latest translations push

kjozwiak pushed a commit to brave/brave-core that referenced this issue Mar 26, 2024
@iccub
[iOS] Add 1.64.x translations. (#22750)
db4621d 
Resolves brave/brave-browser#37073
Resolves brave/brave-browser#37000
Also fixes one duplicated string. It's a debug string so no ticket
created for it.
@kjozwiak kjozwiak mentioned this issue Mar 26, 2024
Closed
25 tasks
@kjozwiak
Copy link
Member

The above requires 1.64.112 or higher for 1.64.x verification 👍

@kjozwiak kjozwiak mentioned this issue Mar 26, 2024
Merged
24 tasks
kjozwiak pushed a commit to brave/brave-core that referenced this issue Mar 26, 2024
@iccub
[iOS] Add 1.64.x translations. (Downlift to 1.65.x) (#22751)
3f99a23 
[iOS] Add 1.64.x translations.

Resolves brave/brave-browser#37073
Resolves brave/brave-browser#37000
Also fixes one duplicated string. It's a debug string so no ticket
created for it.
kjozwiak pushed a commit to brave/brave-core that referenced this issue Mar 26, 2024
@iccub
[iOS] Add 1.64.x translations. (Downlift to 1.66.x) (#22752)
c145796 
[iOS] Add 1.64.x translations.

Resolves brave/brave-browser#37073
Resolves brave/brave-browser#37000
Also fixes one duplicated string. It's a debug string so no ticket
created for it.
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 12, 2024 •
edited
Loading

Verified on iPhone X running iOS 16.7 using version 1.64 (123)

  • Ensured strings are translated for Leo and settings menus in Catalan.

Settings

Example Example Example
IMG_3738 2 IMG_3740 IMG_3741

Leo

Example Example Example Example
IMG_3742 4 IMG_3743 IMG_3744 IMG_3745 4
IMG_3746 IMG_3747 IMG_3748 IMG_3749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug l10n OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.64.x - Release #2
Development

Successfully merging a pull request may close this issue.

[iOS] Add 1.64.x translations. (Downlift to 1.66.x) brave/brave-core
4 participants
@kjozwiak @iccub @Uni-verse @hffvld