Enable download-bubble feature by default

[simonhong]

Chromium has two features for download bubble

• download-bubble
• download-bubble-v2

When it's enabled, user can see download status from bubble in toolbar instead of download shelf.

STR

1. Launch brave and download any files
2. Check download bubble is shown when downloads start
3. Check download bubble shows each item's download status

cc @rebron

[simonhong]

Can we enable this now from security point of view? cc @diracdeltas @fmarier

[simonhong]

It's enabled on my Chrome Win11 but not on macOS.
It's disabled by default - https://source.chromium.org/chromium/chromium/src/+/main:components/safe_browsing/core/common/features.cc;l=77
Maybe it would be enabled by finch on Win11.

and our download page doesn't fit well with download bubble UI. (macOS)

[stephendonner]

It's enabled on my Chrome Win11 but not on macOS. It's disabled by default - https://source.chromium.org/chromium/chromium/src/+/main:components/safe_browsing/core/common/features.cc;l=77 Maybe it would be enabled by finch on Win11.

and our download page doesn't fit well with download bubble UI. (macOS)

This is already being fixed, thankfully 👍 https://github.com/brave/brave-com-resources/issues/668

[fmarier]

That sounds good to me.

[stephendonner]

Verified PASSED using

Brave	1.50.90 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	macOS Version 11.7.4 (Build 20G1120)

Steps:

1. installed 1.50.x
2. launched Brave
3. loaded https://www.thinkbroadband.com/download
4. context-clicked on http://ipv4.download.thinkbroadband.com:8080/1GB.zip
5. chose Save Link As...
6. clicked Save
7. confirmed download was initially blocked, due to being an http:// resource on an https:// site
8. clicked on the blocked notification
9. clicked on the Continue download button
10. confirmed download resumed
11. confirmed download progress was reflected in the Downloads button
12. clicked on the above button
13. confirmed double-click and context-menu options work as expected

example	example	example	example

example	example	example	example

Also confirmed that both Enable download bubble... flags are set to Default, in brave://flags

---

Verification passed on

Brave	1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Ubuntu 18.04 LTS

Steps:

1. installed 1.50.x
2. launched Brave
3. loaded https://www.thinkbroadband.com/download
4. context-clicked on http://ipv4.download.thinkbroadband.com:8080/1GB.zip
5. chose Save Link As...
6. clicked Save
7. confirmed download was initially blocked, due to being an http:// resource on an https:// site
8. clicked on the blocked notification
9. clicked on the Continue download button
10. confirmed download resumed
11. confirmed download progress was reflected in the Downloads button
12. clicked on the above button
13. confirmed double-click and context-menu options work as expected

blocked notification

progress:

[MadhaviSeelam]

Verification PASSED using

Brave | 1.50.101 Chromium: 111.0.5563.116 (Official Build) beta (64-bit)
-- | --
Revision | ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Case 1: New window - PASSED

1. installed 1.50.101
2. launched Brave
3. loaded https://www.thinkbroadband.com/download
4. context-clicked on http://ipv4.download.thinkbroadband.com:8080/1GB.zip
5. chose Save Link As...
6. clicked Save
7. confirmed download shelf no longer displayed
8. confirmed download bubble is shown in the toolbar
9. confirmed download was initially blocked, due to being an http:// resource on an https:// site
10. clicked on the blocked notification
11. clicked on the Continue download button
12. confirmed download resumed
13. confirmed download progress was reflected in the Downloads button
14. confirmed download progress was reflected in brave://downloads
15. confirmed context-menu options work as expected and successfully completed download and Download icon shown in in the toolbar and brave://downloads show downloaded file

step 4	step 5-6	step 8-10	step 11	step 13	step 14	step 15

brave://flags

Also confirmed that both Enable download bubble... flags are set to Default, in brave://flags

Case 2: New private window - PASSED

1. new profile
2. launched Brave
3. click Hamburger menu > New private window
4. loaded https://ubuntu.com/download/desktop/thank-you?version=22.04.2&architecture=amd64
5. chose Save Link As...
6. clicked Save
7. confirmed download shelf no longer displayed
8. confirmed download progress was reflected in the Downloads button
9. confirmed download progress was reflected in brave://downloads
10. confirmed download successfully completed and shown in Download icon in the toolbar and brave://downloads show downloaded file
11. visited brave://downloads in Normal window
12. confirmed file downloads are not shown

step 7	step 9	step 10	step 11	step 12-13

Case 3: New private window with Tor - PASSED

1. new profile
2. launched Brave
3. click Hamburger menu > New private with Tor window
4. loaded https://www.thinkbroadband.com/download
5. checked Verify you are human checkbox
6. context-clicked on http://ipv4.download.thinkbroadband.com:8080/200GB.zip
7. chose Save Link As...
8. clicked Save
9. confirmed download shelf no longer displayed
10. confirmed download was initially blocked, due to being an http:// resource on an https:// site
11. clicked on the blocked notification
12. clicked on the Continue download button
13. confirmed download resumed
14. confirmed download progress was reflected in the Downloads button
15. confirmed download progress was reflected in brave://downloads
16. confirmed context-menu options work as expected and successfully completed download and Download icon shown in in the toolbar and brave://downloads show downloaded file
17. visited brave://downloads in Normal window
18. confirmed filed downloads are not shown

step 4	step 5	step 6	step 11	step 12	step 14	step 15	step 16	step 18

Case 4: Guest window -PASSED

1. new profile
2. launched Brave
3. click Hamburger menu > open guest window
4. loaded https://www.thinkbroadband.com/download
5. context-clicked on http://ipv4.download.thinkbroadband.com:8080/512MB.zip
6. chose Save Link As...
7. clicked Save
8. confirmed download shelf no longer displayed
9. confirmed download was initially blocked, due to being an http:// resource on an https:// site
10. clicked on the blocked notification
11. clicked on the Continue download button
12. confirmed download resumed
13. confirmed download progress was reflected in the Downloads button
14. confirmed download progress was reflected in brave://downloads
15. confirmed context-menu options work as expected and successfully completed download and Download icon shown in in the toolbar and brave://downloads downloaded file
16. visited brave://downloads in Normal window
17. confirmed filed downloads are not shown

step 5	step 7	step 10	step 11	step 13	step 14	step 16	step 17

Case 5: Additional functionality in the download bubble - Pause, Resume, Cancel, Retry- PASSED

1. new profile
2. launched Brave
3. loaded https://ubuntu.com/download/desktop/thank-you?version=22.04.2&architecture=amd64
4. chose Save Link As...
5. clicked Save
6. confirmed download shelf no longer displayed
7. confirmed download progress was reflected in the Downloads button
8. clicked Downloads icon and Pause the download in the downloads dialog
9. confirmed download paused and shown brave://downloads
10. resumed download
11. confirmed download resumed
12. clicked x to cancel the download
13. confirmed download is cancelled and shown in the download bubble and brave://downloads
14. clicked Retry in brave://downloads`
15. confirmed download restarted and download progress was reflected in the Downloads button and in brave://downloads
16. confirmed download successfully completed and shown in Download icon in the toolbar and brave://downloads show downloaded file

step 4-5	step 7	step 8-9	step 10-11	step 12-13	step 14	step 15-16	step 17

Case 6: Upgrade - PASSED

1. Install 1.49.120
2. launch Brave
3. loaded https://www.thinkbroadband.com/download
4. context-clicked on http://ipv4.download.thinkbroadband.com:8080/1GB.zip
5. chose Save Link As...
6. clicked Save
7. verified download message shown on the download shelf.
8. clicked Keep
9. click Exit and close the browser
10. renamed the profile to Brave-Browser-Beta
11. installed 1.50.101
12. launched Brave
13. opened brave://downloads and clicked Retry
14. clicked Save
15. confirmed download progress was reflected in the Downloads button
16. confirmed download progress was reflected in brave://downloads
17. confirmed context-menu options work as expected and successfully completed download and Download icon shown in in the toolbar and brave://downloads downloaded file

step 1	step 4	step 6	step 8	step 9	step 13	step 14	step 15	step 16	step 17

Note: Download button styling issue: #29324

[ArkadiuszNiemiec]

The Ask where to save each file before downloading option is ignored in incognito. Is that intended? If yes, then can we get a flag for it? Before the bubble change, it was auto downloading in incognito for me.
@stephendonner

[diracdeltas]

The Ask where to save each file before downloading option is ignored in incognito. Is that intended? If yes, then can we get a flag for it? Before the bubble change, it was auto downloading in incognito for me.

this sounds like a bug. cc @mkarolin

[mkarolin]

@ArkadiuszNiemiec, I wasn't able to reproduce. Is there a specific webpage you could point me to where you encountered this behavior? Thanks.

[ArkadiuszNiemiec]

@ArkadiuszNiemiec, I wasn't able to reproduce. Is there a specific webpage you could point me to where you encountered this behavior? Thanks.

I just use the link from top: http://ipv4.download.thinkbroadband.com:8080/1GB.zip

Maybe there's something wrong on my setup, but I did not change anything other than update the Brave. I recorded it:

[mkarolin]

@ArkadiuszNiemiec Thank you for the additional info and the video. I initially thought it wasn't asking with the option turned on, but the problem is it still asks in the private window when the option is toggled to off. Created a new issue for this: #29823

[cyfra80]

This option is very annoying, the previous way of downloading was much friendlier.
Such changes should not be forced, it should be an option in the settings at most.
This is a very bad move.

[second2falcon]

@cyfra80 I agree, but the problem is that Google beinh Google has decided the faith of modern internet browsers yet again. Google changed the Chromium code base which is used by Brave (and a lot of other browsers).

If I saw the Git commits in the Chromium repo correctly it shouldn't be too much work to add it back though (could be wrong as I don't know a lot about programming).

See Chromium GIT for the mentioned file changes.