Skip to content

Commit eab176f

Browse files
committed
Enabled chromium's download bubble features by default
fix brave/brave-browser#28562
1 parent 5a8b32f commit eab176f

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

app/brave_main_delegate_browsertest.cc

+3
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
#include "chrome/browser/ui/profile_picker.h"
5151
#include "chrome/browser/ui/ui_features.h"
5252
#include "chrome/test/base/in_process_browser_test.h"
53+
#include "components/safe_browsing/core/common/features.h"
5354
#include "components/translate/core/common/translate_util.h"
5455
#include "extensions/common/extension_features.h"
5556
#endif
@@ -214,6 +215,8 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, EnabledFeatures) {
214215
&features::kWinrtGeolocationImplementation,
215216
#endif
216217
#if !BUILDFLAG(IS_ANDROID)
218+
&safe_browsing::kDownloadBubble,
219+
&safe_browsing::kDownloadBubbleV2,
217220
&sharing_hub::kDesktopScreenshots,
218221
#endif
219222
&media::kEnableTabMuting,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
/* Copyright (c) 2023 The Brave Authors. All rights reserved.
2+
* This Source Code Form is subject to the terms of the Mozilla Public
3+
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
4+
* You can obtain one at https://mozilla.org/MPL/2.0/. */
5+
6+
#include "src/components/safe_browsing/core/common/features.cc"
7+
8+
#include "base/feature_override.h"
9+
#include "build/build_config.h"
10+
11+
namespace safe_browsing {
12+
13+
// Download bubble is desktop only feature.
14+
#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_IOS)
15+
OVERRIDE_FEATURE_DEFAULT_STATES({{
16+
{kDownloadBubble, base::FEATURE_ENABLED_BY_DEFAULT},
17+
{kDownloadBubbleV2, base::FEATURE_ENABLED_BY_DEFAULT},
18+
}});
19+
#endif
20+
21+
} // namespace safe_browsing

0 commit comments

Comments
 (0)