Allow for VPN on Release channel

[bsclifton]

Test plan

1. Wait until 1.46 is on Release channel
2. Visit brave://flags/#brave-vpn
3. Verify VPN shows and you can enable it
4. Relaunch after enabling and verify VPN button shows (next to hamburger menu)

For Linux, confirm flag is not available and no VPN UI shows.

Description

Changes needed so that VPN can move from Beta to Release with 1.46 😄

VPN functionality is tied to the Beta/Dev/Nightly channel at the moment. We should expose this feature on brave://flags/#brave-vpn for Release also. It will still have the default value of false

[LaurenWags]

Labelling as QA/Blocked until we have a release channel build with 1.46.x.

[LaurenWags]

Removing QA/Blocked as we now have at least one 1.46.x RC

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.46.130 Chromium: 108.0.5359.62 (Official Build) (64-bit)
-- | --
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS | Windows 10 Version 21H2 (Build 19044.2251)

• Verified the STR from the description and ensured below:
  • Ensured VPN flag can be enabled via brave://flags in RC
  • Ensured VPN can be purchased via account.bravesoftware.com in RC
  • Ensured creadentials are loaded successfully message is shown after purchasing the VPN
  • Ensured VPN can be enabled via VPN panel in the browser
  • Ensured VPN gets connected to nearest region by default
  • Ensured that VPN status remained enabled upon browser restart
  • Ensured that the default VPN region can be changed to other regions
  • If user has multiple profiles (Profile 1 and Profile 2), enable VPN in profile 1 enables the VPN in Profile 2 as well
  • Change the region in Profile 1 propagate the changes in Profile 2 and vice versa,both profile points to same IP via IPleak.net
  • Ensured VPN in the panel is disabled when VPN is disabled via windows VPN settings
  • Ensured VPN can be enabled via Hamburger menu->Brave VPN menu option
  • Ensured VPN can be disabled via Hamburger menu->Brave VPN menu option
  • Ensured VPN can be reconnected via windows VPN settings
  • Ensured VPN status is shown correctly in windows settings when VPN is connected/disconnected
  • Installed 1.46.129 and enabled Brave VPN and then upgraded the profile to 1.46.130 and ensured VPN status remained enabled after the upgrade

Clean profile

Example	Example

• Ensured VPN UI is not shown when brave vpn flag is in "Default" state
  

Upgrade profile

• Installed 1.45.133 and upgraded the profile to 1.46.130 and ensured VPN is not enabled by default
• Ensured that VPN flag is available under brave://flags in an upgraded profile 1.46.130
• Ensured VPN flag can be enabled and VPN can be purchased in an upgraded profile
• Ensured VPN can be enabled in an upgraded profile

Example	Example	Example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.46.130 Chromium: 108.0.5359.62 (Official Build) (64-bit)
-- | --
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS | Windows 11 Version 21H2 (Build 22000.1219)

New profile

1. Install 1.46.130
2. launch Brave
3. purchase VPN and complete the setup
4. open brave://flags/#brave-vpn
5. confirmed the #brave-vpn flag is set to Default in Release channel
6. confirmed VPN button is not available in toolbar next hamburger menu
7. confirmed Show VPN button entry not shown in brave://settings/appearance
8. confirmed VPN flag can be enabled via brave://flags/#brave-vpn in RC
9. confirmed VPN button is available in toolbar next hamburger menu
10. confirmed Show VPN button entry shown in brave://settings/appearance
11. confirmed VPN can be purchased via account.bravesoftware.com in RC
12. confirmed credentials are loaded successfully message is shown after purchasing the VPN
13. confirmed VPN can be enabled via VPN panel in the browser
14. confirmed VPN gets connected to nearest region by default (US - West)
15. confirmed that VPN is status remained enabled upon browser restart
16. confirmed that the default VPN region can be updated to other regions
17. If user has multiple profiles (Profile 1 and Profile 2), enable VPN in profile 1 enables the VPN in Profile 2 as well
18. Change the region in Profile 1 propagate the changes in Profile 2 and vice versa,both profile points to same IP via IPleak.net
19. confirmed VPN in the panel is disabled when VPN is disabled via windows VPN settings
20. confirmed VPN can be enabled via Hamburger menu->Brave VPN menu option
21. confirmed VPN can be disabled via Hamburger menu->Brave VPN menu option
22. confirmed VPN can be reconnected via windows VPN settings
23. confirmed VPN status is shown correctly in windows settings when VPN is connected/disconnected
24. confirmed 1.46.129 and enabled Brave VPN and then upgraded the profile to 1.46.130 and ensured VPN status remained enabled

Before enabling VPN

step 5	step6	step 7

After enabling VPN

step 8	step 9	step 10	step 12	step 13-14	step 16	step 17-18	step 19	step 20	step 21

Upgraded profile:

• Installed 1.45.133 and upgraded the profile to 1.46.130 and ensured VPN is not enabled by default
• Ensured that VPN flag is available under brave://flags in an upgraded profile 1.46.130
• Ensured VPN flag can be enabled and VPN can be purchased in an upgraded profile
• Ensured VPN can be enabled in an upgraded profile

1.45.133	brave://flags	1.46.130	brave://flags	vpn enabled

[btlechowski]

Verification passed on

Brave	1.46.131 Chromium: 108.0.5359.71 (Official Build) (64-bit)
Revision	1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS	Ubuntu 18.04 LTS

Verified vpn flag is not available brave://flags/#brave-vpn

Verified no VPN UI present

[stephendonner]

Verification PASSED using

Brave	1.46.131 Chromium: 108.0.5359.71 (Official Build) (x86_64)
Revision	1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS	macOS Version 13.1 (Build 22C5050e)

• Verified the STR from the description and ensured below:
  • Ensured VPN flag can be enabled via brave://flags in the release-candidate builds
  • Ensured VPN can be purchased via account.bravesoftware.com in the release-candidate builds
  • Ensured Credentials are loaded successfully! message is shown after purchasing the VPN plan
  • Ensured VPN can be enabled via VPN panel in the browser
  • Ensured VPN gets connected to nearest region by default
  • Ensured that VPN status remained enabled upon browser restart
  • Ensured that the default VPN region can be changed to other regions
  • If user has multiple profiles (Profile 1 and Profile 2), enable VPN in profile 1 enables the VPN in Profile 2 as well
  • Change the region in Profile 1 propagate the changes in Profile 2 and vice versa,both profile points to same IP via IPleak.net
  • Ensured VPN in the panel is disabled when VPN is disabled via macOS Network -> VPN panel settings
  • Ensured VPN can be enabled via "Hamburger" menu -> Brave VPN menu option
  • Ensured VPN can be disabled via "Hamburger" menu -> Brave VPN menu option
  • Ensured VPN can be reconnected via macOS Network -> VPN panel settings
  • Ensured VPN status is shown correctly in macOS Network / VPN settings when VPN is connected/disconnected
  • Installed 1.46.129 and enabled Brave VPN and then upgraded the profile to 1.46.130 and ensured VPN status remained enabled after the upgrade

Clean profile

Example	Example	Example	Example	Example

• Ensured VPN UI is not shown when brave vpn flag is in "Default" state

Upgrade profile

• Installed 1.45.133 and upgraded the profile to 1.46.130 and ensured VPN is not enabled by default
• Ensured that VPN flag is available under brave://flags in an upgraded profile 1.46.130
• Ensured VPN flag can be enabled and VPN can be purchased in an upgraded profile
• Ensured VPN can be enabled in an upgraded profile

Example	Example	Example	Example