Skip to content

[Brave News] The Brave News subscribe button should be enabled by default #26847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fallaciousreasoning opened this issue Nov 18, 2022 · 13 comments · Fixed by brave/brave-core#16009
Closed

[Brave News] The Brave News subscribe button should be enabled by default #26847

fallaciousreasoning opened this issue Nov 18, 2022 · 13 comments · Fixed by brave/brave-core#16009
Assignees
@fallaciousreasoning
Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.46.x - Release #7

Comments

@fallaciousreasoning
Copy link

Currently, the feature is behind a flag. We should add a pref for showing and hiding it, configurable through settings and use that instead.
@fallaciousreasoning fallaciousreasoning mentioned this issue Nov 18, 2022
Merged
25 tasks
@stephendonner stephendonner added the feature/brave-news formerly brave-today label Nov 22, 2022
@stephendonner
Copy link

We should fix #26262 before enabling this by default (obvious, but just wanted to make it explicit so we don't forget).

@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Nov 29, 2022
@stephendonner
Copy link

stephendonner commented Nov 29, 2022 •
edited
Loading

Steps:

  1. install 1.48.x
  2. launch Brave
  3. open brave://flags
  4. look for brave://flags/#brave-news-subscribe-button and ensure it's missing
  5. load planet.mozilla.org
  6. wait
  7. confirm the new RSS-feed icon in the URL bar appears, and is functional

@fallaciousreasoning fallaciousreasoning mentioned this issue Nov 29, 2022
Merged
@fallaciousreasoning
Copy link
Author

Note: This actually removes the flag, it's only behind a pref now.

@stephendonner
Copy link

Note: This actually removes the flag, it's only behind a pref now.

Thanks; I updated the steps in #26847 (comment)

@kjozwiak
Copy link
Member

The above requires 1.47.108 or higher for 1.47.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.47.110 Chromium: 108.0.5359.71 (Official Build) beta (x86_64)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS macOS Version 13.1 (Build 22C5059b)

Steps:

  1. installed 1.47.110
  2. launched Brave
  3. opened brave://flags
  4. searched for button and confirmed the button flag has been removed
  5. loaded theatlantic.com
  6. clicked on the Manage Subscriptions RSS-feed icon

Confirmed the Manage Subscriptions RSS feed icon was updated and worked

example example example example
Screenshot 2022-12-03 at 4 59 46 PM Screenshot 2022-12-03 at 4 58 18 PM Screenshot 2022-12-03 at 4 59 26 PM Screenshot 2022-12-03 at 4 59 31 PM

@btlechowski
Copy link

Verification passed on

Brave 1.47.115 Chromium: 108.0.5359.94 (Official Build) beta (64-bit)
Revision 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS Ubuntu 18.04 LTS

Steps:

  1. installed 1.47.x
  2. launched Brave
  3. opened brave://flags
  4. searched for button and confirmed the button flag has been removed
  5. loaded theatlantic.com
  6. clicked on the Manage Subscriptions RSS-feed icon

Confirmed the Manage Subscriptions RSS feed icon was updated and worked

image
image
image
image
image

Found some issues but they are fixed by #27057 (comment)

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.47.115 Chromium: 108.0.5359.94 (Official Build) beta (64-bit)
-- | --
Revision | 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS | Windows 11 Version 21H2 (Build 22000.1219)

Steps:

  1. installed 1.47.110
  2. launched Brave
  3. scroll down and click Turn on Brave News
  4. opened brave://flags
  5. searched for button and confirmed the button flag has been removed
  6. loaded theatlantic.com
  7. clicked on the Manage Subscriptions RSS-feed icon

Confirmed the Manage Subscriptions RSS feed icon was updated and worked

ex1 ex2 ex3 ex4 ex5 ex6
image image image image image image

@fallaciousreasoning fallaciousreasoning mentioned this issue Dec 19, 2022
Merged
@kjozwiak
Copy link
Member

Unfortunately it sounds like this needed to go into the 1.46.x maintenance release but was missed. I'll get this uplifted into 1.46.x and reset the QA Pass labels. Shouldn't be hard to re-verify. If we don't end up getting another chromium bump for C108, we'll just move this back into 1.47.x and re-add the QA Pass labels as we already checked 1.47.x.

@kjozwiak
Copy link
Member

The above requires 1.46.148 or higher for 1.46.x verification 👍

@LaurenWags LaurenWags mentioned this issue Jan 6, 2023
Closed
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.46.153 Chromium: 108.0.5359.128 (Official Build) (64-bit)
-- | --
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Steps:

  1. installed 1.46.153
  2. launched Brave
  3. scroll down and click Turn on Brave News
  4. opened brave://flags
  5. searched for button and confirmed the button flag has been removed
  6. loaded theatlantic.com
  7. clicked on the Manage Subscriptions RSS-feed icon

Confirmed the Manage Subscriptions RSS feed icon was updated and worked

step 3 step 4-5 step6-7 result result
image image image image image

@LaurenWags
Copy link
Member

LaurenWags commented Jan 6, 2023 •
edited
Loading

Verified with

Brave	1.46.153 Chromium: 108.0.5359.128 (Official Build) (64-bit) 
Revision	1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS	Linux

Steps:

  1. installed 1.47.x
  2. launched Brave
  3. scroll down and click Turn on Brave News
  4. opened brave://flags
  5. searched for button and confirmed the button flag has been removed
  6. loaded theatlantic.com
  7. clicked on the Manage Subscriptions RSS-feed icon

Confirmed the Manage Subscriptions RSS feed icon was displayed and I was able to follow one of the feeds

Example Example Example Example
Screen Shot 2023-01-06 at 2 50 31 PM Screen Shot 2023-01-06 at 2 52 28 PM Screen Shot 2023-01-06 at 2 52 44 PM Screen Shot 2023-01-06 at 2 53 11 PM

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.153 Chromium: 108.0.5359.128 (Official Build) (x86_64)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. installed 1.47.x
  2. launched Brave
  3. scroll down and click Turn on Brave News
  4. opened brave://flags
  5. searched for button and confirmed the button flag has been removed
  6. loaded theatlantic.com
  7. clicked on the Manage Subscriptions RSS-feed icon

Confirmed the Manage Subscriptions RSS feed icon was displayed and I was able to follow one of the feeds

example example example example
Screen Shot 2023-01-06 at 12 03 41 PM Screen Shot 2023-01-06 at 12 05 18 PM Screen Shot 2023-01-06 at 12 05 27 PM Screen Shot 2023-01-06 at 12 05 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release #7
Development

Successfully merging a pull request may close this issue.

[Brave News] Remove Brave News Subscribe button flag brave/brave-core
7 participants
@stephendonner @kjozwiak @fallaciousreasoning @LaurenWags @btlechowski @brave-builds @MadhaviSeelam