Skip to content

Re-enable infobar for default browser prompt #25929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonhong opened this issue Oct 12, 2022 · 3 comments · Fixed by brave/brave-core#15427
Closed

Re-enable infobar for default browser prompt #25929

simonhong opened this issue Oct 12, 2022 · 3 comments · Fixed by brave/brave-core#15427

Comments

@simonhong
Copy link
Member

simonhong commented Oct 12, 2022

Use upstream's infobar for default browser asking

  1. Set non brave as a default default browser
  2. Launch brave with clean profile
  3. Create NTP and relaunch
  4. Check default browser infobar is visible
  5. Click set default button and relaunch
  6. Check infobar is not visible anymore
  7. Set non brave as a default browser and relaunch Brave
  8. Check infobar is visible
  9. Dismiss infobar by clicking x and relaunch
  10. Check infobar is not visible

Note: after dismiss, infobar is not shown again. To make visible, we should provide refresh period via griffin.
Or, this dismiss flag is cleared when user set Brave as a default.

From the bool ShouldShowDefaultBrowserPrompt(Profile* profile), it checks refresh days after dismissed.
As we don't provide this value yet, it's not shown again. This will be handled by #25930

    base::StringToInt(variations::GetVariationParamValue(
                          "DefaultBrowserInfobar", "RefreshPeriodDays"),
@simonhong simonhong self-assigned this Oct 12, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 12, 2022
simonhong added a commit to brave/brave-core that referenced this issue Oct 13, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 13, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 18, 2022

Verification PASSED using

Brave | 1.46.64 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
-- | --
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Pre-requisites:

  • open windows settings>Apps>Default Apps
  • set Firefox as a default browser
image

Case 1: Infobar is visible

  1. Install 1.46.64
  2. Follow pre-requisite steps
  3. launch Brave
  4. click Maybe Later on the first run dialog Ready for the best privacy online?
  5. click to open NTP
  6. close Brave
  7. relaunch Brave

Confirmed the infobar Brave isn't your default browser with Set as default button is displayed

step4 step 5 result
image image image

Case 2: Dismiss the infobar

  1. continue from Case 1
  2. click x on the infobar
  3. close and relaunch Brave
  4. Infobar is no longer available
  5. brave://settings still show Make default button
step2 step 5
image image

Case 3: brave://settings

  1. new profile
  2. follow pre-requisites
  3. launch Brave
  4. click Maybe Later on the first run dialog Ready for the best privacy online?
  5. click to open NTP
  6. close Brave
  7. relaunch Brave
  8. do not click Set as default button in the infobar
  9. open brave://settings
  10. Make default button is displayed
  11. click Make default button
  12. Brave is your default browser tab is displayed
  13. go to slack and click on any link

Confirmed Brave Nightly is default browser as the link opened in Brave Nightly as expected

step 8 step 11 step 12 result
image image image image

Case 4: Set Brave as a default from infobar

  1. follow pre-requisites
  2. new profile
  3. launch Brave
  4. click Maybe Later on the first run dialog Ready for the best privacy online?
  5. click to open NTP
  6. close Brave
  7. relaunch Brave
  8. click Set as default button on the infobar
  9. infobar is no longer visible
  10. open brave://settings
  11. Brave is your default browser tab is displayed
  12. go to slack and click on any link

Confirmed Brave Nightly is default browser as the link opened in Brave Nightly as expected

step 4 step 8 Step 10-11 step 13
image image image image

Case :5: Set Brave as a default from first run dialog - No infobar is available

  1. Follow pre-requisite steps
  2. new profile
  3. click Set Brave as default button on the first run dialog
  4. click to open NTP
  5. close and relaunch the browser
  6. no infobar is visible
step 1 step 3 step 6
image image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.86 Chromium: 107.0.5304.91 (Official Build) beta (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Pre-requisites:

  1. opened Apple -> System Preferences -> General
  2. under Default web browser, choose Firefox.app
Screen Shot 2022-10-31 at 10 10 44 AM

Case 1: infobar is visible - PASSED

  1. followed pre-requisite steps
  2. launched Brave
  3. clicked Maybe later on the first-run dialog Ready for the best privacy online?
  4. opened a new-tab page
  5. closed Brave
  6. relaunched Brave

Confirmed the infobar Brave isn't your default browser, with Set as default was shown

Screen Shot 2022-10-31 at 10 20 12 AM

Case 2: dismiss the infobar - PASSED

  1. continue from Case 1
  2. click x on the infobar
  3. close and relaunch Brave
  4. infobar is no longer available
  5. brave://settings still shows Make default button
step 2 step 5
Screen Shot 2022-10-31 at 10 20 12 AM Screen Shot 2022-10-31 at 10 27 17 AM

Case 3: brave://settings - PASSED

  1. new profile
  2. follow pre-requisites
  3. launch Brave
  4. click Maybe Later on the first run dialog Ready for the best privacy online?
  5. click to open NTP
  6. close Brave
  7. relaunch Brave
  8. do not click Set as default button in the infobar
  9. open brave://settings
  10. Make default button is displayed
  11. click Make default button
  12. Brave is your default browser tab is displayed
  13. go to Slack and click on any link
step 8 step 10 step 11 step 12 result
Screen Shot 2022-10-31 at 10 33 29 AM Screen Shot 2022-10-31 at 10 34 24 AM Screen Shot 2022-10-31 at 10 35 00 AM Screen Shot 2022-10-31 at 10 35 07 AM Screen Shot 2022-10-31 at 10 35 51 AM

Case 4: Set Brave as default from infobar - PASSED

  1. followed pre-requisites
  2. new profile
  3. launched Brave
  4. clicked Maybe Later on the first-run dialog Ready for the best privacy online?
  5. clicked to open NTP
  6. closed Brave
  7. relaunched Brave
  8. clicked Set as default button on the infobar
  9. infobar is no longer visible
  10. opened brave://settings
  11. Brave is your default browser tab is displayed
  12. went to Slack and clicked on a link
step 4 step 8 step 10-11 result
Screen Shot 2022-10-31 at 10 49 03 AM Screen Shot 2022-10-31 at 10 50 51 AM Screen Shot 2022-10-31 at 10 51 56 AM Screen Shot 2022-10-31 at 10 54 57 AM

Confirmed Brave Beta is default browser as the link opened in Brave Beta as expected

Case 5: Set Brave as a default from first run dialog - No infobar is available - PASSED

  1. follow pre-requisite steps
  2. new profile
  3. clicked Set Brave as default button on the first-run dialog
  4. clicked Skip welcome tour to open NTP
  5. closed and relaunched the browser

Confirmed no infobar is visible

step 1 step 3 step 3b result
Screen Shot 2022-10-31 at 11 09 03 AM Screen Shot 2022-10-31 at 11 05 38 AM Screen Shot 2022-10-31 at 11 11 53 AM Screen Shot 2022-10-31 at 11 13 29 AM

@LaurenWags
Copy link
Member

LaurenWags commented Nov 11, 2022

Verified with

Brave	1.46.106 Chromium: 107.0.5304.110 (Official Build) beta (64-bit) 
Revision	2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS	Linux

Pre-requisites:

  1. opened Settings -> Default Applications
  2. under Web, choose Firefox Web Browser
Screen Shot 2022-11-11 at 12 25 38 PM

Case 1: infobar is visible - PASSED

  1. followed pre-requisite steps
  2. launched Brave
  3. clicked Maybe later on the first-run dialog Ready for the best privacy online?
  4. opened a new-tab page
  5. closed Brave
  6. relaunched Brave

Confirmed the infobar Brave isn't your default browser, with Set as default was shown

Screen Shot 2022-11-11 at 2 10 34 PM

Case 2: dismiss the infobar - PASSED

  1. continue from Case 1
  2. click x on the infobar
  3. close and relaunch Brave
  4. infobar is no longer available
  5. brave://settings still shows Make default button
step 2 step 5
2 5

Case 3: brave://settings - PASSED

  1. new profile
  2. follow pre-requisites
  3. launch Brave
  4. click Maybe Later on the first run dialog Ready for the best privacy online?
  5. click to open NTP
  6. close Brave
  7. relaunch Brave
  8. do not click Set as default button in the infobar
  9. open brave://settings
  10. Make default button is displayed
  11. Brave is your default browser tab is displayed
  12. go to a different application and click on any link
step 8 step 10 step 11 step 12
8 10 11 12

Case 4: Set Brave as default from infobar - PASSED

  1. followed pre-requisites
  2. new profile
  3. launched Brave
  4. clicked Maybe Later on the first-run dialog Ready for the best privacy online?
  5. clicked to open NTP
  6. closed Brave
  7. relaunched Brave
  8. clicked Set as default button on the infobar
  9. infobar is no longer visible
  10. opened brave://settings
  11. Brave is your default browser tab is displayed
  12. went to another application and clicked on a link

Confirmed Brave Beta is default browser as the link opened in Brave Beta as expected

step 8 step 10-11 step 12
1 2 3

Case 5: Set Brave as a default from first run dialog - No infobar is available - PASSED

  1. follow pre-requisite steps
  2. new profile
  3. clicked Set Brave as default button on the first-run dialog
  4. clicked Skip welcome tour to open NTP
  5. closed and relaunched the browser

Confirmed no infobar is visible

step 1 step 3 step 5
1 3 5

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 11, 2022
@rebron rebron changed the title Re-enable infobar for default browser ask Re-enable infobar for default browser prompt Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants