Re-enabled default browser infobar

fix brave/brave-browser#25929

Author: simonhong

app/brave_generated_resources.grd

@@ -485,25 +485,6 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext
         </message>
       </if>
 
-      <!-- Brave default browser dialog -->
-      <if expr="not is_android">
-        <message name="IDS_BRAVE_DEFAULT_BROWSER_DIALOG_HEADER_TEXT" desc="The header text for default browser dialog">
-          Set Brave as your default browser
-        </message>
-        <message name="IDS_BRAVE_DEFAULT_BROWSER_DIALOG_CONTENTS_TEXT" desc="The contents for default browser dialog">
-          Keep browsing the web faster - up to 6x faster on major news sites.
-        </message>
-        <message name="IDS_BRAVE_DEFAULT_BROWSER_DIALOG_DONT_ASK" desc="The text for disabling default browser dialog checkbox">
-          Don't ask again
-        </message>
-        <message name="IDS_BRAVE_DEFAULT_BROWSER_DIALOG_OK_BUTTON_LABEL" desc="The text for default browser dialog ok button">
-          Set as default
-        </message>
-        <message name="IDS_BRAVE_DEFAULT_BROWSER_DIALOG_CANCEL_BUTTON_LABEL" desc="The text for default browser dialog cancel button">
-          Not now
-        </message>
-      </if>
-
       <!-- Web Discovery dialog -->
       <if expr="not is_android">
         <message name="IDS_WEB_DISCOVERY_DIALOG_HEADER_TEXT" desc="The text for web discovery dialog header">

browser/brave_local_state_prefs.cc

@@ -59,6 +59,11 @@ void RegisterLocalStatePrefsForMigration(PrefRegistrySimple* registry) {
 #if BUILDFLAG(ENABLE_WIDEVINE)
   RegisterWidevineLocalstatePrefsForMigration(registry);
 #endif
+
+#if !BUILDFLAG(IS_ANDROID)
+  // Added 10/2022
+  registry->RegisterBooleanPref(kDefaultBrowserPromptEnabled, true);
+#endif
 }
 
 void RegisterLocalStatePrefs(PrefRegistrySimple* registry) {
@@ -100,8 +105,6 @@ void RegisterLocalStatePrefs(PrefRegistrySimple* registry) {
   BraveWindowTracker::RegisterPrefs(registry);
   BraveUptimeTracker::RegisterPrefs(registry);
   dark_mode::RegisterBraveDarkModeLocalStatePrefs(registry);
-
-  registry->RegisterBooleanPref(kDefaultBrowserPromptEnabled, true);
 #endif
 
 #if BUILDFLAG(ENABLE_CRASH_DIALOG)

browser/brave_prefs_browsertest.cc

@@ -188,11 +188,6 @@ IN_PROC_BROWSER_TEST_F(BraveProfilePrefsBrowserTest, MediaRouterPrefTest) {
 }
 
 IN_PROC_BROWSER_TEST_F(BraveLocalStatePrefsBrowserTest, DefaultLocalStateTest) {
-#if !BUILDFLAG(IS_ANDROID)
-  EXPECT_TRUE(g_browser_process->local_state()->GetBoolean(
-      kDefaultBrowserPromptEnabled));
-#endif
-
 #if BUILDFLAG(ENABLE_CRASH_DIALOG)
   EXPECT_FALSE(
       g_browser_process->local_state()->GetBoolean(kDontAskForCrashReporting));

browser/brave_profile_prefs.cc

@@ -128,7 +128,6 @@
 
 #if !BUILDFLAG(IS_ANDROID)
 #include "brave/browser/search_engines/search_engine_provider_util.h"
-#include "brave/browser/ui/startup/default_brave_browser_prompt.h"
 #include "brave/browser/ui/tabs/brave_tab_prefs.h"
 #include "brave/components/brave_private_new_tab_ui/common/pref_names.h"
 #endif
@@ -164,6 +163,9 @@ void RegisterProfilePrefsForMigration(
 
   // Added 06/2022
   brave::RegisterSearchEngineProviderPrefsForMigration(registry);
+
+  // Added 10/2022
+  registry->RegisterIntegerPref(kDefaultBrowserLaunchingCount, 0);
 #endif
   brave_wallet::RegisterProfilePrefsForMigration(registry);
 
@@ -440,7 +442,6 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
                                 base::Value(true));
   registry->RegisterBooleanPref(kEnableWindowClosingConfirm, true);
   registry->RegisterBooleanPref(kEnableClosingLastTab, true);
-  RegisterDefaultBraveBrowserPromptPrefs(registry);
 
   brave_tabs::RegisterBraveProfilePrefs(registry);
 #endif

browser/ui/BUILD.gn

@@ -95,8 +95,6 @@ source_set("ui") {
       "omnibox/brave_omnibox_client_impl.cc",
       "omnibox/brave_omnibox_client_impl.h",
       "session_crashed_bubble_brave.cc",
-      "startup/default_brave_browser_prompt.cc",
-      "startup/default_brave_browser_prompt.h",
       "toolbar/brave_app_menu_model.cc",
       "toolbar/brave_app_menu_model.h",
       "toolbar/brave_recent_tabs_sub_menu_model.h",
@@ -195,8 +193,6 @@ source_set("ui") {
     sources += [
       "views/bookmarks/bookmark_bar_instructions_view.cc",
       "views/bookmarks/bookmark_bar_instructions_view.h",
-      "views/brave_default_browser_dialog_view.cc",
-      "views/brave_default_browser_dialog_view.h",
       "views/brave_first_run_dialog.cc",
       "views/brave_first_run_dialog.h",
       "views/brave_layout_provider.cc",

browser/ui/browser_dialogs.h

@@ -14,7 +14,6 @@ class WebContents;
 
 namespace brave {
 
-void ShowDefaultBrowserDialog(Browser* browser);
 // Tab restore dialog will be launched after ask dialog is closed.
 void ShowCrashReportPermissionAskDialog(Browser* browser);
 void ShowWebDiscoveryDialog(Browser* browser, content::WebContents* contents);