Skip to content

blank settings for Brave Auto Contribute and Direct Donations panels #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LaurenWags opened this issue Sep 24, 2018 · 1 comment · Fixed by brave/brave-core#536
Closed

Comments

@LaurenWags
Copy link
Member

Description

After enabling Brave Rewards, the Brave Auto Contribute and Direct Donations panels show informational text to the user until a site is visited or the page is refreshed (per discussion with @NejcZdovc this is by design to educate the user). However, if a user clicks on the settings icon, the panel is blank (no settings shown) and looks broken. Refresh of the page fixes this but it looks bad.

Steps to Reproduce

  1. Clean profile with 0.55.6
  2. Navigate to chrome://rewards.
  3. Enable Brave Rewards.
  4. Click on the settings button in the Brave Auto Contribute or Direct Donations panel.

Actual result:

Panel turns white, no way to go back to text. Refresh of the page fixes this.
blank-settings

Expected result:

Either display the settings or remove the icon so the user can't get into this state.

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Reproducible on current release:

n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags
Copy link
Member Author

LaurenWags commented Oct 9, 2018

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment