[CLOSED] Remove deprecated code using the old preferences system

[core-ai-bot]

Issue by sprintr
Friday Aug 26, 2016 at 22:41 GMT
Originally opened as adobe/brackets#12720

---

Follow up of #12182

---

sprintr included the following code: https://github.com/adobe/brackets/pull/12720/commits

[core-ai-bot]

Comment by zaggino
Friday Aug 26, 2016 at 22:49 GMT

---

To be merged for 1.9, we're nearing 1.8 release (I hope) so it'd be better to merge after release. Methods have been deprecated for over a year so it's time to remove them.

[core-ai-bot]

Comment by le717
Monday Nov 21, 2016 at 16:15 GMT

---

1.8 has been released and we are currently in 1.9. Time to merge this, maybe? :D

[core-ai-bot]

Comment by ficristo
Monday Nov 21, 2016 at 16:24 GMT

---

@le717 is there any difference with your PR?

[core-ai-bot]

Comment by le717
Monday Nov 21, 2016 at 16:26 GMT

---

@ficristo Other than this one being up-to-date (and maybe more through) and me not having the Brackets source on my computer, probably not. Just merge this one and credit@sprintr. It's cool. :)

[core-ai-bot]

Comment by ficristo
Monday Nov 21, 2016 at 16:33 GMT

---

not having the Brackets source on my computer

😢

[core-ai-bot]

Comment by sprintr
Monday Nov 21, 2016 at 17:01 GMT

---

Or merge@le717's PR, I don't even have a brackets installation. ;)

[core-ai-bot]

Comment by ficristo
Monday Nov 21, 2016 at 17:09 GMT

---

I don't even have a brackets installation

😢

[core-ai-bot]

Comment by zaggino
Tuesday Nov 22, 2016 at 20:57 GMT

---

Merged, gives us time to catch problems before next release if they arise.