Skip to content

[PM-18858] Use int.TryParse for plurality helper #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Apr 8, 2025

🎟️ Tracking

PM-18858

📔 Objective

The AzureQueueMailService serializes the mail message request which is then processed by the AzureQueueMailHostedService. During this serialization process, the "number" argument for the new plurality helper is converted to a string and needs to be TryParsed into an integer before being evaluated.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

sonarqubecloud bot commented Apr 8, 2025

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.72%. Comparing base (65f382e) to head (ca2a168).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../Services/Implementations/HandlebarsMailService.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5625   +/-   ##
=======================================
  Coverage   45.72%   45.72%           
=======================================
  Files        1600     1600           
  Lines       72600    72604    +4     
  Branches     6502     6504    +2     
=======================================
+ Hits        33193    33197    +4     
+ Misses      37990    37989    -1     
- Partials     1417     1418    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shane-melton shane-melton merged commit f5f8d37 into main Apr 8, 2025
53 checks passed
@shane-melton shane-melton deleted the vault/pm-18858/template-helper-fix branch April 8, 2025 18:13
Copy link
Contributor

github-actions bot commented Apr 8, 2025

Logo
Checkmarx One – Scan Summary & Detailsa934c8b9-6ef5-4fc7-8157-d44bf12b40fa

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants