[PM-18858] Use int.TryParse for plurality helper (#5625)

shane-melton · web-flow · commit f5f8d37d72ad · 2025-04-08T11:13:47.000-07:00
diff --git a/src/Core/Services/Implementations/HandlebarsMailService.cs b/src/Core/Services/Implementations/HandlebarsMailService.cs
@@ -804,12 +804,10 @@ string constructAnchorElement(string email)
                 return;
             }
 
-            var numeric = parameters[0];
-            var singularText = parameters[1].ToString();
-            var pluralText = parameters[2].ToString();
-
-            if (numeric is int number)
+            if (int.TryParse(parameters[0].ToString(), out var number))
             {
+                var singularText = parameters[1].ToString();
+                var pluralText = parameters[2].ToString();
                 writer.WriteSafeString(number == 1 ? singularText : pluralText);
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -804,12 +804,10 @@ string constructAnchorElement(string email)`
`804`	`804`	`return;`
`805`	`805`	`}`
`806`	`806`
`807`		`- var numeric = parameters[0];`
`808`		`- var singularText = parameters[1].ToString();`
`809`		`- var pluralText = parameters[2].ToString();`
`810`		`-`
`811`		`- if (numeric is int number)`
	`807`	`+ if (int.TryParse(parameters[0].ToString(), out var number))`
`812`	`808`	`{`
	`809`	`+ var singularText = parameters[1].ToString();`
	`810`	`+ var pluralText = parameters[2].ToString();`
`813`	`811`	`writer.WriteSafeString(number == 1 ? singularText : pluralText);`
`814`	`812`	`}`
`815`	`813`	`else`