-
-
Notifications
You must be signed in to change notification settings - Fork 645
chore: remove style rule migration #6746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a87afad The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions regarding the changeset, which felt a bit developer centered and, thus, unclear
.changeset/muddy-migrations-melt.md
Outdated
"@biomejs/biome": minor | ||
--- | ||
|
||
Style runs that were enabled for users coming from Biome 1.x are no longer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Style runs" isn't something that users are aware of. Users only know about biome migrate
. What about this, as alternative?
`biome migrate` no longer enables style rules that were recommended in v1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a typo 😅 but yeah.
.changeset/muddy-migrations-melt.md
Outdated
Users who are upgrading from Biome 1.x are therefore advised to first upgrade to | ||
Biome 2.0, before continuing to Biome 2.1 or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users who are upgrading from Biome 1.x are therefore advised to first upgrade to | |
Biome 2.0, before continuing to Biome 2.1 or later. | |
If you relied on recommended style rules on v1, you're advised to first upgrade to | |
Biome 2.0, run the `biome migrate` command, and then upgrade to Biome 2.1. |
Summary
Style runs that were enabled for users coming from Biome 1.x are no longer re-enabled by the migration script, because that would be undesirable for users coming from 2.0.
Users who are upgrading from Biome 1.x are therefore advised to first upgrade to Biome 2.0, before continuing to Biome 2.1 or later.
Test Plan
Everything should stay green.