Skip to content

chore: remove style rule migration #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Jul 7, 2025

Summary

Style runs that were enabled for users coming from Biome 1.x are no longer re-enabled by the migration script, because that would be undesirable for users coming from 2.0.

Users who are upgrading from Biome 1.x are therefore advised to first upgrade to Biome 2.0, before continuing to Biome 2.1 or later.

Test Plan

Everything should stay green.

@arendjr arendjr requested review from a team July 7, 2025 09:07
Copy link

changeset-bot bot commented Jul 7, 2025

🦋 Changeset detected

Latest commit: a87afad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@biomejs/biome Minor
@biomejs/cli-win32-x64 Minor
@biomejs/cli-win32-arm64 Minor
@biomejs/cli-darwin-x64 Minor
@biomejs/cli-darwin-arm64 Minor
@biomejs/cli-linux-x64 Minor
@biomejs/cli-linux-arm64 Minor
@biomejs/cli-linux-x64-musl Minor
@biomejs/cli-linux-arm64-musl Minor
@biomejs/wasm-web Minor
@biomejs/wasm-bundler Minor
@biomejs/wasm-nodejs Minor
@biomejs/backend-jsonrpc Patch
@biomejs/js-api Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-CLI Area: CLI label Jul 7, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions regarding the changeset, which felt a bit developer centered and, thus, unclear

"@biomejs/biome": minor
---

Style runs that were enabled for users coming from Biome 1.x are no longer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Style runs" isn't something that users are aware of. Users only know about biome migrate. What about this, as alternative?

`biome migrate` no longer enables style rules that were recommended in v1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a typo 😅 but yeah.

Comment on lines 9 to 10
Users who are upgrading from Biome 1.x are therefore advised to first upgrade to
Biome 2.0, before continuing to Biome 2.1 or later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users who are upgrading from Biome 1.x are therefore advised to first upgrade to
Biome 2.0, before continuing to Biome 2.1 or later.
If you relied on recommended style rules on v1, you're advised to first upgrade to
Biome 2.0, run the `biome migrate` command, and then upgrade to Biome 2.1.

@arendjr arendjr merged commit 90aeead into biomejs:main Jul 7, 2025
11 checks passed
@github-actions github-actions bot mentioned this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants