Skip to content

Commit 90aeead

Browse files
arendjrarendjr
authored
chore: remove style rule migration (#6746)
1 parent 788fd84 commit 90aeead

28 files changed

+40
-3144
lines changed

‎.changeset/muddy-migrations-melt.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
"@biomejs/biome": minor
3+
---
4+
5+
`biome migrate` no longer enables style rules that were recommended in v1,
6+
because that would be undesirable for users upgrading from 2.0.
7+
8+
Users who are upgrading from Biome 1.x are therefore advised to first upgrade to
9+
Biome 2.0, and run the migration, before continuing to Biome 2.1 or later.

‎crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_migrate_aws_config.snap

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,7 @@ expression: redactor(content)
3333
"useConsistentArrayType": {
3434
"level": "error",
3535
"options": { "syntax": "shorthand" }
36-
},
37-
"noParameterAssign": "error",
38-
"useAsConstAssertion": "error",
39-
"useDefaultParameterLast": "error",
40-
"useEnumInitializers": "error",
41-
"useSelfClosingElements": "error",
42-
"useSingleVarDeclarator": "error",
43-
"noUnusedTemplateLiteral": "error",
44-
"useNumberNamespace": "error",
45-
"noInferrableTypes": "error",
46-
"noUselessElse": "error"
36+
}
4737
},
4838
"suspicious": {
4939
"noEmptyBlockStatements": "error"

‎crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_migrate_issue_5465.snap

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,7 @@ expression: redactor(content)
3333
"strictCase": false
3434
}
3535
},
36-
"noDefaultExport": "error",
37-
"noParameterAssign": "error",
38-
"useAsConstAssertion": "error",
39-
"useDefaultParameterLast": "error",
40-
"useEnumInitializers": "error",
41-
"useSelfClosingElements": "error",
42-
"useSingleVarDeclarator": "error",
43-
"noUnusedTemplateLiteral": "error",
44-
"useNumberNamespace": "error",
45-
"noInferrableTypes": "error",
46-
"noUselessElse": "error"
36+
"noDefaultExport": "error"
4737
},
4838
"correctness": {
4939
"noConstantCondition": "error",

‎crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_migrate_nested_config.snap

Lines changed: 6 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -27,76 +27,22 @@ expression: redactor(content)
2727
2828
i Configuration file can be updated.
2929
30-
1 │ - {·"linter":·{·"rules":·{·"recommended":·true·}·}·}
31-
1 │ + {·"root":·false,"linter":·{
32-
2 │ + ····"rules":·{"recommended":·true·,
33-
3 │ + ······"style":·{
34-
4 │ + ········"noParameterAssign":·"error",
35-
5 │ + ········"useAsConstAssertion":·"error",
36-
6 │ + ········"useDefaultParameterLast":·"error",
37-
7 │ + ········"useEnumInitializers":·"error",
38-
8 │ + ········"useSelfClosingElements":·"error",
39-
9 │ + ········"useSingleVarDeclarator":·"error",
40-
10 │ + ········"noUnusedTemplateLiteral":·"error",
41-
11 │ + ········"useNumberNamespace":·"error",
42-
12 │ + ········"noInferrableTypes":·"error",
43-
13 │ + ········"noUselessElse":·"error"
44-
14 │ + ······}
45-
15 │ + ····}
46-
16 │ + ··}·}
47-
30+
1 │ {·"root":·false,"linter":·{·"rules":·{·"recommended":·true·}·}·}
31+
│ ++++++++++++++
4832
4933
```
5034
5135
```block
52-
<TEMP_DIR>/should_migrate_nested_config/biome.json migrate ━━━━━━━━━━━━━━━━━━━━
53-
54-
i Configuration file can be updated.
55-
56-
1 │ - {·"linter":·{·"rules":·{·"recommended":·true·}·}·}
57-
1 │ + {·"linter":·{
58-
2 │ + ····"rules":·{"recommended":·true·,
59-
3 │ + ······"style":·{
60-
4 │ + ········"noParameterAssign":·"error",
61-
5 │ + ········"useAsConstAssertion":·"error",
62-
6 │ + ········"useDefaultParameterLast":·"error",
63-
7 │ + ········"useEnumInitializers":·"error",
64-
8 │ + ········"useSelfClosingElements":·"error",
65-
9 │ + ········"useSingleVarDeclarator":·"error",
66-
10 │ + ········"noUnusedTemplateLiteral":·"error",
67-
11 │ + ········"useNumberNamespace":·"error",
68-
12 │ + ········"noInferrableTypes":·"error",
69-
13 │ + ········"noUselessElse":·"error"
70-
14 │ + ······}
71-
15 │ + ····}
72-
16 │ + ··}·}
73-
74-
36+
Your configuration file is up to date.
7537
```
7638
7739
```block
7840
<TEMP_DIR>/should_migrate_nested_config/foo/biome.json migrate ━━━━━━━━━━━━━━━━━━━━
7941
8042
i Configuration file can be updated.
8143
82-
1 │ - {·"linter":·{·"rules":·{·"recommended":·true·}·}·}
83-
1 │ + {·"root":·false,"linter":·{
84-
2 │ + ····"rules":·{"recommended":·true·,
85-
3 │ + ······"style":·{
86-
4 │ + ········"noParameterAssign":·"error",
87-
5 │ + ········"useAsConstAssertion":·"error",
88-
6 │ + ········"useDefaultParameterLast":·"error",
89-
7 │ + ········"useEnumInitializers":·"error",
90-
8 │ + ········"useSelfClosingElements":·"error",
91-
9 │ + ········"useSingleVarDeclarator":·"error",
92-
10 │ + ········"noUnusedTemplateLiteral":·"error",
93-
11 │ + ········"useNumberNamespace":·"error",
94-
12 │ + ········"noInferrableTypes":·"error",
95-
13 │ + ········"noUselessElse":·"error"
96-
14 │ + ······}
97-
15 │ + ····}
98-
16 │ + ··}·}
99-
44+
1 │ {·"root":·false,"linter":·{·"rules":·{·"recommended":·true·}·}·}
45+
│ ++++++++++++++
10046
10147
```
10248
@@ -106,7 +52,7 @@ configuration ━━━━━━━━━━━━━━━━━━━━━━
10652
i Migration results:
10753
10854
- <TEMP_DIR>/should_migrate_nested_config/bar/biome.json: configuration needs migration.
109-
- <TEMP_DIR>/should_migrate_nested_config/biome.json: configuration needs migration.
55+
- <TEMP_DIR>/should_migrate_nested_config/biome.json: no migration needed.
11056
- <TEMP_DIR>/should_migrate_nested_config/foo/biome.json: configuration needs migration.
11157
11258
i Use --write to apply the changes.

‎crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_successfully_migrate_ariakit.snap

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,7 @@ expression: redactor(content)
6060
"noParameterAssign": "off",
6161
"noUnusedTemplateLiteral": "off",
6262
"noNonNullAssertion": "off",
63-
"noUselessElse": "off",
64-
"useAsConstAssertion": "error",
65-
"useDefaultParameterLast": "error",
66-
"useEnumInitializers": "error",
67-
"useSelfClosingElements": "error",
68-
"useSingleVarDeclarator": "error",
69-
"useNumberNamespace": "error",
70-
"noInferrableTypes": "error"
63+
"noUselessElse": "off"
7164
}
7265
}
7366
}

‎crates/biome_cli/tests/snapshots/main_cases_migrate_v2/should_successfully_migrate_knip.snap

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,6 @@ expression: redactor(content)
3434
"style": {
3535
"noParameterAssign": "off",
3636
"useNodeAssertStrict": "error",
37-
"useAsConstAssertion": "error",
38-
"useDefaultParameterLast": "error",
39-
"useEnumInitializers": "error",
40-
"useSelfClosingElements": "error",
41-
"useSingleVarDeclarator": "error",
42-
"noUnusedTemplateLiteral": "error",
43-
"useNumberNamespace": "error",
44-
"noInferrableTypes": "error",
45-
"noUselessElse": "error",
4637
"noRestrictedImports": {
4738
"level": "error",
4839
"options": {

‎crates/biome_cli/tests/snapshots/main_commands_migrate/migrate_config_up_to_date.snap

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,8 @@ biome.json migrate ━━━━━━━━━━━━━━━━━━━━
1515
1616
i Configuration file can be updated.
1717
18-
1 │ - {·"linter":·{·"enabled":·true·}·}
19-
1 │ + {·"root":·false,"linter":·{"enabled":·true·,
20-
2 │ + ····"rules":·{
21-
3 │ + ······"style":·{
22-
4 │ + ········"noParameterAssign":·"error",
23-
5 │ + ········"useAsConstAssertion":·"error",
24-
6 │ + ········"useDefaultParameterLast":·"error",
25-
7 │ + ········"useEnumInitializers":·"error",
26-
8 │ + ········"useSelfClosingElements":·"error",
27-
9 │ + ········"useSingleVarDeclarator":·"error",
28-
10 │ + ········"noUnusedTemplateLiteral":·"error",
29-
11 │ + ········"useNumberNamespace":·"error",
30-
12 │ + ········"noInferrableTypes":·"error",
31-
13 │ + ········"noUselessElse":·"error"
32-
14 │ + ······}
33-
15 │ + ····}
34-
16 │ + ··}·}
35-
18+
1 │ {·"root":·false,"linter":·{·"enabled":·true·}·}
19+
│ ++++++++++++++
3620
3721
```
3822

‎crates/biome_cli/tests/snapshots/main_commands_migrate/should_migrate_nested_files.snap

Lines changed: 20 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -39,27 +39,12 @@ expression: redactor(content)
3939
4040
i Configuration file can be updated.
4141
42-
1 1 │ {
43-
2 │ - ····"organizeImports":·{
44-
3 │ - ········"enabled":·true
45-
2 │ + ····"assist":·{·"actions":·{·"source":·{·"organizeImports":·"on"·}·}·},
46-
3 │ + ··"linter":·{
47-
4 │ + ····"rules":·{
48-
5 │ + ······"style":·{
49-
6 │ + ········"noParameterAssign":·"error",
50-
7 │ + ········"useAsConstAssertion":·"error",
51-
8 │ + ········"useDefaultParameterLast":·"error",
52-
9 │ + ········"useEnumInitializers":·"error",
53-
10 │ + ········"useSelfClosingElements":·"error",
54-
11 │ + ········"useSingleVarDeclarator":·"error",
55-
12 │ + ········"noUnusedTemplateLiteral":·"error",
56-
13 │ + ········"useNumberNamespace":·"error",
57-
14 │ + ········"noInferrableTypes":·"error",
58-
15 │ + ········"noUselessElse":·"error"
59-
16 │ + ······}
60-
4 17 │ }
61-
18 │ + ··}
62-
5 19 │ }
42+
1 1 │ {
43+
2 │ - ····"organizeImports":·{
44+
3 │ - ········"enabled":·true
45+
4 │ - ····}
46+
2 │ + ····"assist":·{·"actions":·{·"source":·{·"organizeImports":·"on"·}·}·}
47+
5 3 │ }
6348
6449
6550
```
@@ -69,28 +54,13 @@ expression: redactor(content)
6954
7055
i Configuration file can be updated.
7156
72-
1 1 │ {
73-
2 │ - ····"organizeImports":·{
74-
3 │ - ········"enabled":·true
75-
2 │ + ····"root":·false,
76-
3 │ + ····"assist":·{·"actions":·{·"source":·{·"organizeImports":·"on"·}·}·},
77-
4 │ + ··"linter":·{
78-
5 │ + ····"rules":·{
79-
6 │ + ······"style":·{
80-
7 │ + ········"noParameterAssign":·"error",
81-
8 │ + ········"useAsConstAssertion":·"error",
82-
9 │ + ········"useDefaultParameterLast":·"error",
83-
10 │ + ········"useEnumInitializers":·"error",
84-
11 │ + ········"useSelfClosingElements":·"error",
85-
12 │ + ········"useSingleVarDeclarator":·"error",
86-
13 │ + ········"noUnusedTemplateLiteral":·"error",
87-
14 │ + ········"useNumberNamespace":·"error",
88-
15 │ + ········"noInferrableTypes":·"error",
89-
16 │ + ········"noUselessElse":·"error"
90-
17 │ + ······}
91-
4 18 │ }
92-
19 │ + ··}
93-
5 20 │ }
57+
1 1 │ {
58+
2 │ - ····"organizeImports":·{
59+
3 │ - ········"enabled":·true
60+
4 │ - ····}
61+
2 │ + ····"root":·false,
62+
3 │ + ····"assist":·{·"actions":·{·"source":·{·"organizeImports":·"on"·}·}·}
63+
5 4 │ }
9464
9565
9666
```
@@ -100,28 +70,13 @@ expression: redactor(content)
10070
10171
i Configuration file can be updated.
10272
103-
1 1 │ {
104-
2 │ - ····"organizeImports":·{
105-
3 │ - ········"enabled":·true
106-
2 │ + ····"root":·false,
107-
3 │ + ····"assist":·{·"actions":·{·"source":·{·"organizeImports":·"on"·}·}·},
108-
4 │ + ··"linter":·{
109-
5 │ + ····"rules":·{
110-
6 │ + ······"style":·{
111-
7 │ + ········"noParameterAssign":·"error",
112-
8 │ + ········"useAsConstAssertion":·"error",
113-
9 │ + ········"useDefaultParameterLast":·"error",
114-
10 │ + ········"useEnumInitializers":·"error",
115-
11 │ + ········"useSelfClosingElements":·"error",
116-
12 │ + ········"useSingleVarDeclarator":·"error",
117-
13 │ + ········"noUnusedTemplateLiteral":·"error",
118-
14 │ + ········"useNumberNamespace":·"error",
119-
15 │ + ········"noInferrableTypes":·"error",
120-
16 │ + ········"noUselessElse":·"error"
121-
17 │ + ······}
122-
4 18 │ }
123-
19 │ + ··}
124-
5 20 │ }
73+
1 1 │ {
74+
2 │ - ····"organizeImports":·{
75+
3 │ - ········"enabled":·true
76+
4 │ - ····}
77+
2 │ + ····"root":·false,
78+
3 │ + ····"assist":·{·"actions":·{·"source":·{·"organizeImports":·"on"·}·}·}
79+
5 4 │ }
12580
12681
12782
```

‎crates/biome_migrate/src/analyzers.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ use crate::analyzers::no_restriected_globals::NoRestrictedGlobals;
55
use crate::analyzers::organize_imports::OrganizeImports;
66
use crate::analyzers::rule_mover::RuleMover;
77
use crate::analyzers::schema::Schema;
8-
use crate::analyzers::style_rules::StyleRules;
98
use crate::analyzers::trailing_comma::TrailingComma;
109
use crate::analyzers::use_naming_convention_enum_member_case::UseNamingConventionEnumMemberCase;
1110
use biome_analyze::{GroupCategory, RegistryVisitor, RuleCategory, RuleGroup};
@@ -18,7 +17,6 @@ mod no_restriected_globals;
1817
mod organize_imports;
1918
mod rule_mover;
2019
mod schema;
21-
mod style_rules;
2220
mod trailing_comma;
2321
mod use_naming_convention_enum_member_case;
2422

@@ -36,7 +34,6 @@ impl RuleGroup for MigrationGroup {
3634
registry.record_rule::<Schema>();
3735
// v2.0.0
3836
registry.record_rule::<RulesAll>();
39-
registry.record_rule::<StyleRules>();
4037
registry.record_rule::<OrganizeImports>();
4138
registry.record_rule::<RuleMover>();
4239
registry.record_rule::<Includes>();

0 commit comments

Comments
 (0)