use wgpu TextureDataOrder #19829
Merged
use wgpu TextureDataOrder #19829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
approved these changes
Jun 27, 2025
Elabajaba
approved these changes
Jun 27, 2025
atlv24
added
A-Rendering
brianreavis
reviewed
Jun 27, 2025
| // Assign the data and fill in the rest of the metadata now the possible | ||
| // error cases have been handled | ||
| let mut image = Image::default(); | ||
| image.texture_descriptor.format = texture_format; | ||
| image.data = Some(wgpu_data.into_iter().flatten().collect::<Vec<_>>()); | ||
| image.data = Some(levels.into_iter().flatten().collect::<Vec<_>>()); |
There was a problem hiding this comment.
This doesn't need to block merging imo, but fwiw: when benchmarking on #18411, I found that levels.flatten().collect() suffers from unnecessary vec resizing. Pre-calculating a capacity and using extend was faster.
There was a problem hiding this comment.
i noticed you wrote it differently, ive been chopping little bits off of that PR to make it easier to reason about in isolation. i have a rebased version of it locally i've been tracking. just want to get the simplest bits in first basically
superdump
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MipXLayerYFaceZ#19140Solution
Testing