add native zstd support #19793
Merged
add native zstd support #19793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
approved these changes
Jun 24, 2025
atlv24
added
A-Rendering
Victoronz
approved these changes
Jun 24, 2025
Victoronz
added
S-Ready-For-Final-Review
|
Should this have a small migration guide entry to state that an additional feature is required when using |
|
its a default feature, so unless you're using default-features=false there's no migration |
atlv24
force-pushed
the
zstd
branch
2 times, most recently
from
b48013b to
7c2fb6d
Compare
mockersf
approved these changes
Jun 24, 2025
|
@atlv24 doing |
|
it's mentioned in the migration guide 👍 |
|
Oh thanks, then I'm happy :D |
JMS55
reviewed
Jun 24, 2025
superdump
approved these changes
Jun 24, 2025
atlv24
commented
Jun 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2025
# Objective - add support for alternate zstd backend through `zstd` for faster decompression ## Solution - make existing `zstd` feature only specify that support is required, disambiguate which backend to use via two other features `zstd_native` and `zstd_rust`. - Similar to the approach taken by #18411, but we keep current behavior by defaulting to the rust implementation because its safer, and isolate this change. NOTE: the default feature-set may seem to not currently require `zstd`, but it does, it is enabled transitively by the `tonemapping_luts` feature, which is a default feature. Thus this does not add default features. ## Testing - Cargo clippy on both feature combinations
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
zstdfor faster decompressionSolution
zstdfeature only specify that support is required, disambiguate which backend to use via two other featureszstd_nativeandzstd_rust.NOTE: the default feature-set may seem to not currently require
zstd, but it does, it is enabled transitively by thetonemapping_lutsfeature, which is a default feature. Thus this does not add default features.Testing