-
Notifications
You must be signed in to change notification settings - Fork 38
[MDS-6255] view mine report definitions #3398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8016d87
make the tab, put it on the page, fix the HSRC title
taraepp 643993b
add pagination to mine report definitions in BE, take out of static c…
taraepp 270ddc4
missed adding the slice file
taraepp b03c71c
get the data in the table and pagination working properly with BE pag…
taraepp 9bb1a23
remove mine report definition options from static content, get basics…
taraepp 8956fad
upstream changes
taraepp d47e73d
tell sqlalchemy where a table is
taraepp 70460a7
change loading logic
taraepp 8247171
make fetch happen in other places that use report definitions
taraepp 880fc4f
fix BE filters for boolean values
taraepp 293a372
remove logs
taraepp a07ec85
use string because boolean doesn't work
taraepp 83297df
fix some sorting on BE, fix page size on FE
taraepp 34d0dcd
do FE part of section filter
taraepp 6805875
BE compliance article # search, little bit of clean up on codes page
taraepp da94f62
add backend search, tweak ordering of section sort
taraepp 5d9d845
add api param documentation, take out unecessary param
taraepp af4d599
fix bug with searching section first, put search params in url
taraepp d37567a
FE snapshot test, make params comparison better
taraepp f4517b9
make test fancier
taraepp d9264bc
don't disable buttons
taraepp abc151b
upstream changes - merge conflicts
taraepp f7333a5
fix diff
taraepp 8e04279
upstream changes
taraepp 84e5185
did merge conflict resolution wrong
taraepp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
services/common/src/interfaces/common/searchParams.interface.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export interface ISearchParams { | ||
page?: number; | ||
per_page?: number; | ||
sort_field?: string; | ||
sort_dir?: string; | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,6 @@ const initialState = { | |
informationRequirementsTableDocumentTypes: [], | ||
majorMineApplicationStatusCodes: [], | ||
majorMineApplicationDocumentTypes: [], | ||
mineReportDefinitionOptions: [], | ||
mineReportStatusOptions: [], | ||
mineReportCategoryOptions: [], | ||
partyRelationshipTypes: [], | ||
|
@@ -113,8 +112,6 @@ export const getMajorMinesApplicationStatusCodes = (state) => | |
state[STATIC_CONTENT].majorMineApplicationStatusCodes; | ||
export const getMajorMinesApplicationDocumentTypes = (state) => | ||
state[STATIC_CONTENT].majorMineApplicationDocumentTypes; | ||
export const getMineReportDefinitionOptions = (state) => | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah! |
||
state[STATIC_CONTENT].mineReportDefinitionOptions; | ||
export const getMineReportStatusOptions = (state) => state[STATIC_CONTENT].mineReportStatusOptions; | ||
export const getMineReportCategoryOptions = (state) => | ||
state[STATIC_CONTENT].mineReportCategoryOptions; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels strange that we don't already have this. Nice!