[MDS-6255] view mine report definitions #3398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent, and make a slice on the FE
…ination. TODO: I'm missing data fields, and the sort only applies to data currently on the page
… of sort/filter working (still a bit buggy)
taraepp
requested review from
simensma-fresh,
matbusby-fw,
asinn134 and
sggerard
matbusby-fw
reviewed
Feb 6, 2025
| @@ -0,0 +1,6 @@ | |||
| export interface ISearchParams { | |||
There was a problem hiding this comment.
Feels strange that we don't already have this. Nice!
matbusby-fw
reviewed
Feb 6, 2025
| @@ -113,8 +112,6 @@ export const getMajorMinesApplicationStatusCodes = (state) => | |||
| state[STATIC_CONTENT].majorMineApplicationStatusCodes; | |||
| export const getMajorMinesApplicationDocumentTypes = (state) => | |||
| state[STATIC_CONTENT].majorMineApplicationDocumentTypes; | |||
| export const getMineReportDefinitionOptions = (state) => | |||
matbusby-fw
previously approved these changes
Feb 6, 2025
|
|
|
|
Looks like there's a possibly legit error in a backend test: |
|
matbusby-fw
approved these changes
Feb 7, 2025
asinn134
approved these changes
Feb 7, 2025
|
Nice work!😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TO
DODone:some work with sorting and filteringodd test failures locally, seeing if happens in pipeline(it was an import thing)changed instances where we used the static content reducer to use the new slice, but those instances aren't fetching datawrite more tests!MDS-6255
Why are you making this change? Provide a short explanation and/or screenshots