[MDS-6308] Add permit condition status #3374
Conversation
sggerard
added
the
👍 Ready for review
| ('INP', 'In Progress', 20, 'system-mds', 'system-mds'), | ||
| ('COM', 'Complete', 30, 'system-mds', 'system-mds') | ||
| ON CONFLICT DO NOTHING; | ||
|
|
There was a problem hiding this comment.
I'm wondering if it's necessary to add to this file!
We've run into issues in the past where it's difficult to maintain things that are put here. If it's not necessary, would avoid it
There was a problem hiding this comment.
Counterpoint to that, this is the kind of thing that would get annoying to remind people to enter in themselves. I'd prefer to have it seeded personally.
There was a problem hiding this comment.
Absolutely.
We're just adding these data migrations together with schema migrations instead of using the afterMigrate functionality. So would suggest maybe adding in another.
(example: V2024.06.11.10.03__add_new_document_types_to_project_summary_document_type.sql)
There was a problem hiding this comment.
I had it in both the migration and seed_data. Have removed it from the seed data now.
services/common/src/interfaces/permits/permitCondition.interface.ts
Outdated
Show resolved
Hide resolved
...ices/core-api/app/api/mines/permits/permit_conditions/models/permit_condition_status_code.py
Outdated
Show resolved
Hide resolved
services/core-web/src/components/mine/Permit/PermitConditions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Nice work!
A bit of a dive into lots of the more complicated parts of the code. I agree with some of what Tara was saying in her comments.
- Would probably be good to make that interface property optional
- The one permit amendment message likely won't come up much, but "Permit amendment status code is not provided" specifically could probably be a bit more user friendly. Something like "Permit condition status code missing from request"?
migrations/sql/V2025.01.07.22.23__add_permit_condition_status.sql
Outdated
Show resolved
Hide resolved
|
|
|
|
Objective
MDS-6308
Add statuses to permit conditions.
Please note - when testing you will need to run the database migration and generate new permit conditions as there are additional fields that need to be set.