Skip to content

Commit 704b10b

Browse files
committed
Update PSQL, interface, error message and scss
1 parent b98943f commit 704b10b

File tree

5 files changed

+15
-11
lines changed

5 files changed

+15
-11
lines changed

migrations/sql/V2025.01.07.22.23__add_permit_condition_status.sql

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22

3-
CREATE TABLE permit_condition_status_code
3+
CREATE TABLE IF NOT EXISTS permit_condition_status_code
44
(
55
permit_condition_status_code character varying(3) NOT NULL,
66
description character varying(100) NOT NULL,
@@ -32,15 +32,15 @@ CREATE TABLE permit_condition_status_code
3232
ON CONFLICT DO NOTHING;
3333

3434
ALTER TABLE permit_conditions
35-
ADD COLUMN IF NOT EXISTS permit_condition_status_code character varying(3),
35+
ADD COLUMN IF NOT EXISTS permit_condition_status_code character varying(3) DEFAULT 'NST' NOT NULL,
3636
ADD COLUMN IF NOT EXISTS top_level_parent_permit_condition_id integer,
3737
ADD CONSTRAINT permit_condition_status_code_fkey FOREIGN KEY (permit_condition_status_code)
3838
REFERENCES permit_condition_status_code(permit_condition_status_code),
3939
ADD CONSTRAINT top_level_parent_permit_condition_id_fkey FOREIGN KEY (top_level_parent_permit_condition_id)
4040
REFERENCES permit_conditions(permit_condition_id);
4141

4242
ALTER TABLE permit_conditions_version
43-
ADD COLUMN IF NOT EXISTS permit_condition_status_code character varying(3),
43+
ADD COLUMN IF NOT EXISTS permit_condition_status_code character varying(3) DEFAULT 'NST' NOT NULL,
4444
ADD COLUMN IF NOT EXISTS top_level_parent_permit_condition_id integer,
4545
ADD CONSTRAINT permit_condition_status_code_fkey FOREIGN KEY (permit_condition_status_code)
4646
REFERENCES permit_condition_status_code(permit_condition_status_code),

services/common/src/interfaces/permits/permitCondition.interface.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ export interface IPermitCondition {
1919
condition: string;
2020
condition_type_code: string;
2121
condition_category_code: string;
22-
parent_permit_condition_id: number;
22+
parent_permit_condition_id?: number;
2323
sub_conditions: IPermitCondition[];
2424
step: string;
2525
stepPath?: string;
2626
display_order: number;
2727
mineReportPermitRequirement?: IMineReportPermitRequirement;
2828
meta?: IPermitConditionMeta
2929
permit_condition_status_code: string;
30-
top_level_parent_permit_condition_id: number;
30+
top_level_parent_permit_condition_id?: number;
3131
}
3232

3333
export interface IPermitConditionCategory {

services/core-api/app/api/mines/permits/permit_conditions/models/permit_condition_status_code.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def find_by_permit_condition_status_code(cls, _id):
2424
@validates('permit_condition_status_code')
2525
def validate_permit_condition_status_code(self, key, permit_condition_status_code):
2626
if not permit_condition_status_code:
27-
raise AssertionError('Permit amendment status code is not provided.')
27+
raise AssertionError('Permit condition status code is not provided.')
2828
if len(permit_condition_status_code) > 3:
29-
raise AssertionError('Permit amendment status code must not exceed 3 characters.')
29+
raise AssertionError('Permit condition status code must not exceed 3 characters.')
3030
return permit_condition_status_code

services/core-web/src/components/mine/Permit/PermitConditions.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,9 @@ const PermitConditions: FC<PermitConditionProps> = ({
132132
);
133133

134134
const PERMIT_CONDITION_STATUS = {
135-
complete: {icon: faCheckCircle, color: "#45a766", text: "Complete"},
136-
in_progress: {icon: faClock, color: COLOR.violet, text: "In Progress"},
137-
not_started: {icon: faBan, color: "#bbb", text:"Not Started"}
135+
complete: {icon: faCheckCircle, color: "color-success", text: "Complete"},
136+
in_progress: {icon: faClock, color: "color-primary", text: "In Progress"},
137+
not_started: {icon: faBan, color: "color-gov-grey", text:"Not Started"}
138138
}
139139

140140
const getPermitConditionCategories = (categories, conditions) => {
@@ -197,7 +197,7 @@ const PermitConditions: FC<PermitConditionProps> = ({
197197

198198
return {
199199
href: cat.condition_category_code.toLowerCase().replace("-", ""),
200-
icon: <FontAwesomeIcon icon={status.icon} style={{ color: status.color, fontSize: "20px" }} />,
200+
icon: <FontAwesomeIcon icon={status.icon} className={status.color} style={{ fontSize: "20px" }} />,
201201
title: (
202202
<Typography.Text style={{ fontSize: "16px", fontWeight: "600" }}>
203203
{formatPermitConditionStep(cat.step)}

services/core-web/src/styles/generic/helpers.scss

+4
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
color: theme.$white !important;
2222
}
2323

24+
&-success {
25+
color: variables.$ok-green !important;
26+
}
27+
2428
// Brand Colours
2529
&-gov-grey {
2630
color: variables.$gov-grey !important;

0 commit comments

Comments
 (0)