[FIX] - catch missing orgbook entity and improve logging #3301
Conversation
Jsyro
added
👍 Ready for review
| return datetime(date.year, date.month, date.day, 0, 0, 0, tzinfo=ZoneInfo("UTC")).isoformat() | ||
| def convert_date_to_iso_datetime(datetime: datetime) -> str: | ||
| return datetime( | ||
| datetime.year, datetime.month, datetime.day, 0, 0, 0, tzinfo=ZoneInfo("UTC")).isoformat() |
There was a problem hiding this comment.
Have to check, just because we have a million issues with UTC times- this converts the datetime to UTC, not tells it that the timezone it has is UTC, right?
There was a problem hiding this comment.
datetime objects are natively timezone-unaware.
the python language is deprecating some of these methods in favour or producting timezone-aware datetime objects
well formed VCDM credentials required timezone codes, i could just append T00:00:00 to the string, but this is a more pythonic way to do that and is better understood by future devs
There was a problem hiding this comment.
What that means is existing datetime objects based on UTC don't know they are based on UTC, they are date+time with no timezone information. it's up to the code to know that it's based on UTC, or maybe postgres is automatically adding UTC information?
it's probably something that should become it's own task. to update the python to start using the new timezone-aware methods and classes, update the validators to require timezone-aware objects (or add it), then update remaining datetime values to have timezone information.
There was a problem hiding this comment.
👍
Sounds good. The db does automatically save it as UTC. I appreciate the documentation!
ensure factory is producing a datetime and not a date
|
This line scares me.... |
clicks git blame On the bright side: you've learned something in the last 3 years. |
that's not funny at all. ~~it implies that dates and datetimes are both being used in the code, but the original intention was to only ever store datetime objects. ~~ this one hurts, and on a friday no less. |
| pmt_appt_start_date = pmt_appt.start_date.date() | ||
| else: | ||
| print(type(pmt_appt.start_date)) | ||
| print("WHAT?") |
There was a problem hiding this comment.
😂
Miiiiiight want something else for an error log message. A little more context for the rest of us.
|
No description provided.