Issue permits as vc with mdt #1634
Conversation
skips if permittee is not related to orgbook entity
Jsyro
added
🌶 Enhancement
|
Review Reminders
|
…to Issue-permits-as-VC-with-MDT
Could build the service out into a proper singleton initialized on app start up with a threaded init/readyness check
…to Issue-permits-as-VC-with-MDT
| mine, permit = create_mine_and_permit() | ||
| MinePartyAppointmentFactory(permit=permit, permittee=True) | ||
| with current_app.test_request_context() as a, patch( | ||
| 'app.api.services.issue_to_orgbook_service.requests.post') as mock: |
There was a problem hiding this comment.
This module traversal was getting confused because the app module has an api attribute, when i wanted it to traverse into the api module..
I've renamed the local variable in the file, but i can change it's name or do some more research on if this can be changed.
Jsyro
removed
the
🧪 Needs tests
Signed-off-by: Jason Sy <[email protected]>
Jsyro
added
the
👍 Ready for review
…to Issue-permits-as-VC-with-MDT
| @@ -52,12 +53,12 @@ def create_app(test_config=None): | |||
|
|
|||
| def register_extensions(app): | |||
|
|
|||
| api.app = app | |||
| root_api_namespace.app = app | |||
There was a problem hiding this comment.
I like this better, thanks
| @@ -111,6 +112,11 @@ | |||
| PermitAmendmentResource, | |||
| '/<string:mine_guid>/permits/<string:permit_guid>/amendments/<string:permit_amendment_guid>') | |||
|
|
|||
| api.add_resource( | |||
| PermitAmendmentIssueVCResource, | |||
| '/<string:mine_guid>/permits/<string:permit_guid>/amendments/<string:permit_amendment_guid>/issue-vc-to-orgbook' | |||
There was a problem hiding this comment.
I don't really care if this is POC land, but this should probably be something named more like "/credential" instead of "issue-vc-to-orgbook" which seems super not restful.
There was a problem hiding this comment.
I did make some reversals of making some of the names more generic vs specific. I'll take another pass at this one.
| .then((response) => { | ||
| notification.success({ | ||
| message: `Successfully Issued Permit Verifiable Credentials, Thanks Jason`, | ||
| duration: 10, |
There was a problem hiding this comment.
Please update to "Successfully Issued Permit Verifiable Credentials, Thanks Oh Great Ryan, sole developer of MDS"
…to Issue-permits-as-VC-with-MDT
…to Issue-permits-as-VC-with-MDT
…to Issue-permits-as-VC-with-MDT
Still needs:
Add button (admins only) to call MDT's issuer controller to issue Verifiable Credentials to businesses in orgbook.