Fixed data race in test-setup.sh
#26453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
meisterT
reviewed
Jul 1, 2025
| # We need to wait in a loop because wait is interrupted by any incoming trapped | ||
| # signal (https://www.gnu.org/software/bash/manual/bash.html#Signals). | ||
| while kill -0 $childPid 2>/dev/null; do | ||
| if [[ "$targetExited" == "1" ]]; then | ||
| . "${targetExitCodeFile}" |
There was a problem hiding this comment.
I think this deserves a comment that this will read the exit code from the file.
Btw, is there a scenario where we didn't write the file?
| exitCode=$? | ||
| echo "exitCode=$exitCode" > "${targetExitCodeFile}" | ||
| kill -SIGCHLD $PPID | ||
| while [[ 1 ]]; do sleep 1; done # Stasis. |
iancha1992
added
the
team-OSS
meteorcloudy
added
team-Local-Exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check this out; on some platforms PIDs may be reused without wraparound.
There are two Issues (solved) here: