[5.1.0] cherrypick subpackages support #14780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| <p> | ||
| In general it is preferred that instead of calling this function directly | ||
| that users use the 'subpackages' module of |
There was a problem hiding this comment.
Looks like the docs merged wrong.
There was a problem hiding this comment.
Thanks for the double-check, let me try and fix this.
There was a problem hiding this comment.
Actually, that's from the original. I'll file an issue for @kkress to address this, and then add that fix in after.
There was a problem hiding this comment.
Yeah, it seems like it blew away some existing docs.
PiperOrigin-RevId: 411055066
…function. Design proposal: https://docs.google.com/document/d/13UOT0GoQofxDW40ILzH2sWpUOmuYy6QZ7CUmhej9vgk/edit# This CL modifies the globber infrastructure to support an additional mode of listing sub-directories. * Add new Globber Operation enum allowing, Globber implementations to discriminate between glob, glob w/directories and the future sub-packages use-case. * Modify UnixGlob to replace Predicate and bools with UnixGlobPathDiscriminator interface for: a) Determining whether to traverse a sub-directory (previously was lambda) b) function for determing what entries to include in the List<Path> produced by UnixGlob.globAsync. These allow relatively simple re-use of the same logic for both subpackages and glob 4) Add a few tests for UnixGlob to ensure both cases continue to work as expected. PiperOrigin-RevId: 421125424
Design proposal: https://docs.google.com/document/d/13UOT0GoQofxDW40ILzH2sWpUOmuYy6QZ7CUmhej9vgk/edit# Overview: Add StarlarkNativeModule 'subpackages' function with parameters that mirror glob() PiperOrigin-RevId: 422652954
|
This also requires 41f5c23, re-trying. |
katre
force-pushed
the
5.1.0-subpackages
branch
from
b829095 to
ce076b5
Compare
|
Ahh, the docs were fixed in 4399004, adding that now. |
PiperOrigin-RevId: 425942284
|
@fweikert do we need to anything special here? this cherry-pick PR touches documentation. |
|
Looks good to me. We'll have to cherry pick some more docs changes once they're actually submitted, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherrypicks two commits that comprise subpackage support for Bazel 5.1 (#14714)
Fixes #14716.