Skip to content

Commit 536f8d9

Browse files
fmeumcopybara-github
authored andcommitted
Fix fail message construction in cc_shared_library
Previously, if there were many unaccounted for libraries, this would simply fail with: ``` Error in join: 'string' is not iterable ``` Closes bazelbuild#14697. PiperOrigin-RevId: 440090957
1 parent f51a7b6 commit 536f8d9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main/starlark/builtins_bzl/common/cc/experimental_cc_shared_library.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ def _throw_error_if_unaccounted_libs(unaccounted_for_libs):
359359
libs_message.append(str(unaccounted_lib))
360360

361361
if len(unaccounted_for_libs) > 10:
362-
libs_message = "(and " + str(len(unaccounted_for_libs) - 10) + " others)\n"
362+
libs_message.append("(and " + str(len(unaccounted_for_libs) - 10) + " others)\n")
363363

364364
static_deps_message = []
365365
for repo in different_repos:

0 commit comments

Comments
 (0)