refactor: Bazelrc presets: Almost always use common #1095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practice seems to be to almost always use
common
(reminding me to C++'s AAA rule). Usingcommon
ensures thatbuild
,fetch
, andquery
use the same flags and is easier for users since there is one recommended way to do it.With bazelbuild/bazel#18609, Bazel does not fail in case a flag does not belong to a common, so there is no harm in using common for Bazel 6.3+. Because of this, bazel6.bazelrc does not use common.
I kept all
test
flags as is for now, but we can also make them common if we want, either here or as follow up PR.