refactor: Bazelrc presets: Almost always use common (#1095)

* refactor: Bazelrc presets: Almost always use common

* fix preset tests

Author: hofbi

.aspect/bazelrc/bazel6.bazelrc

@@ -1,3 +1,5 @@
+# Not using common here because https://github.com/bazelbuild/bazel/pull/18609 was added in Bazel 6.3.0
+
 # Speed up all builds by not checking if external repository files have been modified.
 # Docs: https://github.com/bazelbuild/bazel/blob/1af61b21df99edc2fc66939cdf14449c2661f873/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java#L244
 build --noexperimental_check_external_repository_files

.aspect/bazelrc/bazel7.bazelrc

@@ -12,12 +12,12 @@ common --check_direct_dependencies=off
 # Save time on Sandbox creation and deletion when many of the same kind of action run during the
 # build.
 # Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories
-build --reuse_sandbox_directories
+common --reuse_sandbox_directories
 
 # Do not build runfiles symlink forests for external repositories under
 # `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
 # sandbox creation times & prevents accidentally depending on this feature which may flip to off by
 # default in the future. Note, some rules may fail under this flag, please file issues with the rule
 # author.
 # Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
-build --nolegacy_external_runfiles
+common --nolegacy_external_runfiles

.aspect/bazelrc/ci.bazelrc

@@ -15,52 +15,52 @@ test --flaky_test_attempts=2
 # beginning of each Bazel invocation. This is very useful on CI to be able to inspect what Bazel rc
 # settings are being applied on each run.
 # Docs: https://bazel.build/docs/user-manual#announce-rc
-build --announce_rc
+common --announce_rc
 
 # Add a timestamp to each message generated by Bazel specifying the time at which the message was
 # displayed.
 # Docs: https://bazel.build/docs/user-manual#show-timestamps
-build --show_timestamps
+common --show_timestamps
 
 # Only show progress every 60 seconds on CI.
 # We want to find a compromise between printing often enough to show that the build isn't stuck,
 # but not so often that we produce a long log file that requires a lot of scrolling.
 # https://bazel.build/reference/command-line-reference#flag--show_progress_rate_limit
-build --show_progress_rate_limit=60
+common --show_progress_rate_limit=60
 
 # Use cursor controls in screen output.
 # Docs: https://bazel.build/docs/user-manual#curses
-build --curses=yes
+common --curses=yes
 
 # Use colors to highlight output on the screen. Set to `no` if your CI does not display colors.
 # Docs: https://bazel.build/docs/user-manual#color
-build --color=yes
+common --color=yes
 
 # The terminal width in columns. Configure this to override the default value based on what your CI system renders.
 # Docs: https://github.com/bazelbuild/bazel/blob/1af61b21df99edc2fc66939cdf14449c2661f873/src/main/java/com/google/devtools/build/lib/runtime/UiOptions.java#L151
-build --terminal_columns=143
+common --terminal_columns=143
 
 ######################################
 # Generic remote cache configuration #
 ######################################
 
 # Only download remote outputs of top level targets to the local machine.
 # Docs: https://bazel.build/reference/command-line-reference#flag--remote_download_toplevel
-build --remote_download_toplevel
+common --remote_download_toplevel
 
 # The maximum amount of time to wait for remote execution and cache calls.
 # https://bazel.build/reference/command-line-reference#flag--remote_timeout
-build --remote_timeout=3600
+common --remote_timeout=3600
 
 # Upload locally executed action results to the remote cache.
 # Docs: https://bazel.build/reference/command-line-reference#flag--remote_upload_local_results
-build --remote_upload_local_results
+common --remote_upload_local_results
 
 # Fall back to standalone local execution strategy if remote execution fails. If the grpc remote
 # cache connection fails, it will fail the build, add this so it falls back to the local cache.
 # Docs: https://bazel.build/reference/command-line-reference#flag--remote_local_fallback
-build --remote_local_fallback
+common --remote_local_fallback
 
 # Fixes builds hanging on CI that get the TCP connection closed without sending RST packets.
 # Docs: https://bazel.build/reference/command-line-reference#flag--grpc_keepalive_time
-build --grpc_keepalive_time=30s
+common --grpc_keepalive_time=30s

.aspect/bazelrc/convenience.bazelrc

@@ -1,6 +1,6 @@
 # Attempt to build & test every target whose prerequisites were successfully built.
 # Docs: https://bazel.build/docs/user-manual#keep-going
-build --keep_going
+common --keep_going
 
 # Output test errors to stderr so users don't have to `cat` or open test failure log files when test
 # fail. This makes the log noisier in exchange for reducing the time-to-feedback on test failures for
@@ -11,7 +11,7 @@ test --test_output=errors
 # Show the output files created by builds that requested more than one target. This helps users
 # locate the build outputs in more cases
 # Docs: https://bazel.build/docs/user-manual#show-result
-build --show_result=20
+common --show_result=20
 
 # Bazel picks up host-OS-specific config lines from bazelrc files. For example, if the host OS is
 # Linux and you run bazel build, Bazel picks up lines starting with build:linux. Supported OS

.aspect/bazelrc/correctness.bazelrc

@@ -3,14 +3,14 @@
 # It should be flipped to `--remote_upload_local_results` on CI
 # by using `--bazelrc=.aspect/bazelrc/ci.bazelrc`.
 # Docs: https://bazel.build/reference/command-line-reference#flag--remote_upload_local_results
-build --noremote_upload_local_results
+common --noremote_upload_local_results
 
 # Don't allow network access for build actions in the sandbox.
 # Ensures that you don't accidentally make non-hermetic actions/tests which depend on remote
 # services.
 # Developers should tag targets with `tags=["requires-network"]` to opt-out of the enforcement.
 # Docs: https://bazel.build/reference/command-line-reference#flag--sandbox_default_allow_network
-build --sandbox_default_allow_network=false
+common --sandbox_default_allow_network=false
 
 # Warn if a test's timeout is significantly longer than the test's actual execution time.
 # Bazel's default for test_timeout is medium (5 min), but most tests should instead be short (1 min).
@@ -40,15 +40,15 @@ test --incompatible_exclusive_test_sandboxed
 # Use `--action_env=ENV_VARIABLE` if you want to inherit specific environment variables from the
 # client, but note that doing so can prevent cross-user caching if a shared cache is used.
 # Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_strict_action_env
-build --incompatible_strict_action_env
+common --incompatible_strict_action_env
 
 # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong
 # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python
 # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the
 # default), it is treated as false if and only if this flag is set. See
 # https://github.com/bazelbuild/bazel/issues/10076.
 # Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_default_to_explicit_init_py
-build --incompatible_default_to_explicit_init_py
+common --incompatible_default_to_explicit_init_py
 
 # Set default value of `allow_empty` to `False` in `glob()`. This prevents a common mistake when
 # attempting to use `glob()` to match files in a subdirectory that is opaque to the current package
@@ -60,5 +60,5 @@ common --incompatible_disallow_empty_glob
 # downloaded on test result cache hits when --remote_download_minimal is enabled, making it impossible
 # to generate a full coverage report.
 # Docs: https://bazel.build/reference/command-line-reference#flag--experimental_fetch_all_coverage_outputs
-# detching remote cache results
+# ditching remote cache results
 test --experimental_fetch_all_coverage_outputs

.aspect/bazelrc/performance.bazelrc

@@ -3,7 +3,7 @@
 # build.
 # No longer experimental in Bazel 6: https://github.com/bazelbuild/bazel/commit/c1a95501a5611878e5cc43a3cc531f2b9e47835b
 # Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories
-build --experimental_reuse_sandbox_directories
+common --experimental_reuse_sandbox_directories
 
 # Avoid creating a runfiles tree for binaries or tests until it is needed.
 # Docs: https://bazel.build/reference/command-line-reference#flag--build_runfile_links
@@ -12,7 +12,7 @@ build --experimental_reuse_sandbox_directories
 # This may break local workflows that `build` a binary target, then run the resulting program
 # outside of `bazel run`. In those cases, the script will need to call
 # `bazel build --build_runfile_links //my/binary:target` and then execute the resulting program.
-build --nobuild_runfile_links
+common --nobuild_runfile_links
 
 # Needed prior to Bazel 8; see
 # https://github.com/bazelbuild/bazel/issues/20577

lib/tests/bazelrc_presets/subset/convenience.bazelrc

@@ -1,6 +1,6 @@
 # Attempt to build & test every target whose prerequisites were successfully built.
 # Docs: https://bazel.build/docs/user-manual#keep-going
-build --keep_going
+common --keep_going
 
 # Output test errors to stderr so users don't have to `cat` or open test failure log files when test
 # fail. This makes the log noisier in exchange for reducing the time-to-feedback on test failures for
@@ -11,7 +11,7 @@ test --test_output=errors
 # Show the output files created by builds that requested more than one target. This helps users
 # locate the build outputs in more cases
 # Docs: https://bazel.build/docs/user-manual#show-result
-build --show_result=20
+common --show_result=20
 
 # Bazel picks up host-OS-specific config lines from bazelrc files. For example, if the host OS is
 # Linux and you run bazel build, Bazel picks up lines starting with build:linux. Supported OS